[feature]: adding a base_channel_id field to both PeerAcceptedBuyQuoteEvent and PeerAcceptedSellQuoteEvent.

[lukegao209]

When listening to SubscribeRfqEventNtfns, it’s currently possible to receive the RFQ event, but during event handling, there’s no direct way to identify which channel or asset the event relates to. While it’s technically possible to resolve this via the ScidAlias, it adds unnecessary complexity to the event processing logic.

If this feature is deemed useful, I’d be happy to contribute the implementation.

@guggero

[GeorgeTsagk]

Hi @lukegao209

It is true that when we register the RFQ's scid to LND we specify a real channel's base scid, as seen here. But what channel we pick doesn't really matter, as LND will do non-strict forwarding anyway. Any channel with that peer that has an asset specifier that matches the RFQ can be used.

there’s no direct way to identify which channel or asset the event relates to

So short answer: It does not relate to a specific channel, that's why this info is not present. The asset ID / groupkey can be retrieved from the nested field PeerAcceptedBuyQuoteEvent.BuyRequest.AssetSpecifier

[lukegao209]

Hi @lukegao209

It is true that when we register the RFQ's scid to LND we specify a real channel's base scid, as seen here. But what channel we pick doesn't really matter, as LND will do non-strict forwarding anyway. Any channel with that peer that has an asset specifier that matches the RFQ can be used.

there’s no direct way to identify which channel or asset the event relates to

So short answer: It does not relate to a specific channel, that's why this info is not present. The asset ID / groupkey can be

I couldn’t find any BuyRequest information included in the PeerAcceptedBuyQuoteEvent. Is this something that’s available in a newer version?

The main reason I raised this issue is to obtain fields like assetId or groupId when handling the event — currently it’s hard to identify the related asset or channel without this context.