Duplicate on chain txns breaks metrics collection

[ajcurated]

An issue with lnd results in duplicate entries in the on chain transaction list.

This results in metric collection failure as multiple series with the same labels are created.

Error:

An error has occurred while serving metrics:

collected metric "lnd_tx_num_confs" { label:<name:"tx_hash" value:"xxxx" > counter:<value:11894 > } was collected before with the same name and label values

[mrfelton]

Also seeing this

[mrfelton]

Anyone know what the actual root cause of this is?

[carlaKC]

An issue with lnd results in duplicate entries in the on chain transaction list.

@ajcrowe do you have duplicate entries for that tx in lnd's list chain txns? Trying to figure out whether this is a lnd or lndmon issue.

Looks like we don't actually use this metric anywhere, so I'm just going to remove it anyway, but would be good to know what's up.