Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signer: Allow changing channel value and funding pubkey (splicing) #3542

Closed
optout21 opened this issue Jan 15, 2025 · 0 comments · Fixed by #3624
Closed

Signer: Allow changing channel value and funding pubkey (splicing) #3542

optout21 opened this issue Jan 15, 2025 · 0 comments · Fixed by #3624
Assignees
Labels

Comments

@optout21
Copy link
Contributor

Currently when the channel signer is created for a new channel, the channel value is specified, and it is never changed afterwards (SignerProvider, derive_channel_signer). It is assumed that the channel value is constant for the lifetime of a channel. However, this is not the case for splicing. The channel value is used by the signer when signing commitment transactions, but not in the creation of the keys (such as the funding pubkey).

Suggestion(s):

Provide a way to update the channel value in an existing signer. The signer would be kept during splicing (together with the keys), only the channel value would be updated. The initial channel would still be provided at signer creation.

Alternative:

Don't take & store the channel value at all in the Signer, but take it as a parameter in the commitment signing methods.

Currently there is no way to generate a new funding pubkey in channel Signer, only by regenerating the entire Signer, which would change other keys as well (e.g. revocation key).
Provide a way in the Signer to generate (provide?) a new funding key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants