Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a reason enum to HTLCDestination in some variants #3561

Open
TheBlueMatt opened this issue Jan 24, 2025 · 4 comments · May be fixed by #3601
Open

Add a reason enum to HTLCDestination in some variants #3561

TheBlueMatt opened this issue Jan 24, 2025 · 4 comments · May be fixed by #3601
Labels
good first issue Good for newcomers

Comments

@TheBlueMatt
Copy link
Collaborator

It'd be nice if it was explicit why we failed when giving the user a HTLCHandlingFailed - HTLCDestination provides that for many cases, but the NextHopChannel case (and maybe others) can happen for different reasons. It'd be nice if we were explicit about that. Needs someone to go over all the places we build a Event::HTLCHandlingFailed and make sure it has a unique HTLCDestination with enough info.
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Jan 24, 2025
@Harsh1s
Copy link

Harsh1s commented Jan 25, 2025

Hi there, would it be fine if I work on this issue?

@TheBlueMatt
Copy link
Collaborator Author

Go for it!

@valentinewallace valentinewallace mentioned this issue Feb 6, 2025
Merged
@Sumitsh28
Copy link

Can I work on this issue?

@TheBlueMatt
Copy link
Collaborator Author

Looks like this is already being addressed in #3601

@TheBlueMatt TheBlueMatt linked a pull request Mar 5, 2025 that will close this issue
Add a reason to HTLCHandlingFailed event #3601
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a reason to HTLCHandlingFailed event carlaKC/rust-lightning
3 participants
@TheBlueMatt @Harsh1s @Sumitsh28