Skip to content

Commit ec579f0

Browse files
committed
ci: silence unnecessary_map_or lint as solution requires MSRV >= 1.70
Rust 1.84.0 was recently released along with some new clippy lints, one of which is `unnecessary_map_or`. Unfortunately this lint suggests using `Option::is_some_and` as a fix, but this is only available in Rust version >= 1.70, while we still have an MSRV of 1.63. So we silence that lint for now. We'd still like our lint CI to use stable Rust so that we can benefit from new lint checks which may be helpful and don't require an MSRV bump, but sometimes new lints (like in this case) do. See: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some_and
1 parent 0282cfb commit ec579f0

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ci/check-lint.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -93,4 +93,5 @@ RUSTFLAGS='-D warnings' cargo clippy -- \
9393
-A clippy::unnecessary_to_owned \
9494
-A clippy::unnecessary_unwrap \
9595
-A clippy::unused_unit \
96-
-A clippy::useless_conversion
96+
-A clippy::useless_conversion \
97+
-A clippy::unnecessary_map_or `# to be removed once we hit MSRV 1.70`

0 commit comments

Comments
 (0)