Skip to content

Commit afa18d2

Browse files
committed
Remove #[rustfmt::skip] from fn write
Fixed formatting for write() in ChannelMonitorImpl. This would make the next commit cleaner by ensuring it only contains direct code shifts, without unrelated formatting changes.
1 parent 5e4278d commit afa18d2

File tree

1 file changed

+39
-18
lines changed

1 file changed

+39
-18
lines changed

lightning/src/chain/channelmonitor.rs

Lines changed: 39 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1346,7 +1346,6 @@ const SERIALIZATION_VERSION: u8 = 1;
13461346
const MIN_SERIALIZATION_VERSION: u8 = 1;
13471347

13481348
impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
1349-
#[rustfmt::skip]
13501349
fn write<W: Writer>(&self, writer: &mut W) -> Result<(), Error> {
13511350
write_ver_prefix!(writer, SERIALIZATION_VERSION, MIN_SERIALIZATION_VERSION);
13521351

@@ -1356,7 +1355,9 @@ impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
13561355
U48(self.commitment_transaction_number_obscure_factor).write(writer)?;
13571356

13581357
self.destination_script.write(writer)?;
1359-
if let Some(ref broadcasted_holder_revokable_script) = self.broadcasted_holder_revokable_script {
1358+
if let Some(ref broadcasted_holder_revokable_script) =
1359+
self.broadcasted_holder_revokable_script
1360+
{
13601361
writer.write_all(&[0; 1])?;
13611362
broadcasted_holder_revokable_script.0.write(writer)?;
13621363
broadcasted_holder_revokable_script.1.write(writer)?;
@@ -1419,58 +1420,77 @@ impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
14191420
}
14201421
}
14211422

1422-
writer.write_all(&(self.funding.counterparty_claimable_outpoints.len() as u64).to_be_bytes())?;
1423+
writer.write_all(
1424+
&(self.funding.counterparty_claimable_outpoints.len() as u64).to_be_bytes(),
1425+
)?;
14231426
for (ref txid, ref htlc_infos) in self.funding.counterparty_claimable_outpoints.iter() {
14241427
writer.write_all(&txid[..])?;
14251428
writer.write_all(&(htlc_infos.len() as u64).to_be_bytes())?;
14261429
for &(ref htlc_output, ref htlc_source) in htlc_infos.iter() {
1427-
debug_assert!(htlc_source.is_none() || Some(**txid) == self.funding.current_counterparty_commitment_txid
1430+
debug_assert!(
1431+
htlc_source.is_none()
1432+
|| Some(**txid) == self.funding.current_counterparty_commitment_txid
14281433
|| Some(**txid) == self.funding.prev_counterparty_commitment_txid,
1429-
"HTLC Sources for all revoked commitment transactions should be none!");
1434+
"HTLC Sources for all revoked commitment transactions should be none!"
1435+
);
14301436
serialize_htlc_in_commitment!(htlc_output);
14311437
htlc_source.as_ref().map(|b| b.as_ref()).write(writer)?;
14321438
}
14331439
}
14341440

1435-
writer.write_all(&(self.counterparty_commitment_txn_on_chain.len() as u64).to_be_bytes())?;
1441+
writer
1442+
.write_all(&(self.counterparty_commitment_txn_on_chain.len() as u64).to_be_bytes())?;
14361443
for (ref txid, commitment_number) in self.counterparty_commitment_txn_on_chain.iter() {
14371444
writer.write_all(&txid[..])?;
14381445
writer.write_all(&byte_utils::be48_to_array(*commitment_number))?;
14391446
}
14401447

14411448
writer.write_all(&(self.counterparty_hash_commitment_number.len() as u64).to_be_bytes())?;
1442-
for (ref payment_hash, commitment_number) in self.counterparty_hash_commitment_number.iter() {
1449+
for (ref payment_hash, commitment_number) in self.counterparty_hash_commitment_number.iter()
1450+
{
14431451
writer.write_all(&payment_hash.0[..])?;
14441452
writer.write_all(&byte_utils::be48_to_array(*commitment_number))?;
14451453
}
14461454

14471455
if let Some(holder_commitment_tx) = &self.funding.prev_holder_commitment_tx {
14481456
writer.write_all(&[1; 1])?;
14491457
write_legacy_holder_commitment_data(
1450-
writer, holder_commitment_tx, &self.prev_holder_htlc_data.as_ref().unwrap(),
1458+
writer,
1459+
holder_commitment_tx,
1460+
&self.prev_holder_htlc_data.as_ref().unwrap(),
14511461
)?;
14521462
} else {
14531463
writer.write_all(&[0; 1])?;
14541464
}
14551465

14561466
write_legacy_holder_commitment_data(
1457-
writer, &self.funding.current_holder_commitment_tx, &self.current_holder_htlc_data,
1467+
writer,
1468+
&self.funding.current_holder_commitment_tx,
1469+
&self.current_holder_htlc_data,
14581470
)?;
14591471

1460-
writer.write_all(&byte_utils::be48_to_array(self.current_counterparty_commitment_number))?;
1472+
writer
1473+
.write_all(&byte_utils::be48_to_array(self.current_counterparty_commitment_number))?;
14611474
writer.write_all(&byte_utils::be48_to_array(self.current_holder_commitment_number))?;
14621475

14631476
writer.write_all(&(self.payment_preimages.len() as u64).to_be_bytes())?;
14641477
for (payment_preimage, _) in self.payment_preimages.values() {
14651478
writer.write_all(&payment_preimage.0[..])?;
14661479
}
14671480

1468-
writer.write_all(&(self.pending_monitor_events.iter().filter(|ev| match ev {
1469-
MonitorEvent::HTLCEvent(_) => true,
1470-
MonitorEvent::HolderForceClosed(_) => true,
1471-
MonitorEvent::HolderForceClosedWithInfo { .. } => true,
1472-
_ => false,
1473-
}).count() as u64).to_be_bytes())?;
1481+
writer.write_all(
1482+
&(self
1483+
.pending_monitor_events
1484+
.iter()
1485+
.filter(|ev| match ev {
1486+
MonitorEvent::HTLCEvent(_) => true,
1487+
MonitorEvent::HolderForceClosed(_) => true,
1488+
MonitorEvent::HolderForceClosedWithInfo { .. } => true,
1489+
_ => false,
1490+
})
1491+
.count() as u64)
1492+
.to_be_bytes(),
1493+
)?;
14741494
for event in self.pending_monitor_events.iter() {
14751495
match event {
14761496
MonitorEvent::HTLCEvent(upd) => {
@@ -1494,7 +1514,8 @@ impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
14941514
self.best_block.block_hash.write(writer)?;
14951515
writer.write_all(&self.best_block.height.to_be_bytes())?;
14961516

1497-
writer.write_all(&(self.onchain_events_awaiting_threshold_conf.len() as u64).to_be_bytes())?;
1517+
writer
1518+
.write_all(&(self.onchain_events_awaiting_threshold_conf.len() as u64).to_be_bytes())?;
14981519
for ref entry in self.onchain_events_awaiting_threshold_conf.iter() {
14991520
entry.write(writer)?;
15001521
}
@@ -1522,7 +1543,7 @@ impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
15221543
let mut pending_monitor_events = self.pending_monitor_events.clone();
15231544
pending_monitor_events.push(MonitorEvent::HolderForceClosed(*outpoint));
15241545
pending_monitor_events
1525-
}
1546+
},
15261547
_ => self.pending_monitor_events.clone(),
15271548
};
15281549

0 commit comments

Comments
 (0)