Rename manually_handle_bolt12_invoices

1. Till now this UserConfig option was used to indicate whether the user
   wants to handles the payment for received Bolt12Invoices manually.
2. The future commits expand it's use case, so that it can also be used
   to indicate whether the user wants to handle response to the received
Invoice Request manually as well.
3. Rename this UserConfig appropriately to better represent its use
   case.

Author: shaavan

lightning/src/events/mod.rs

@@ -823,7 +823,7 @@ pub enum Event {
 	/// Indicates a [`Bolt12Invoice`] in response to an [`InvoiceRequest`] or a [`Refund`] was
 	/// received.
 	///
-	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_invoices`] is set.
+	/// This event will only be generated if [`UserConfig::manually_handle_bolt12_messages`] is set.
 	/// Use [`ChannelManager::send_payment_for_bolt12_invoice`] to pay the invoice or
 	/// [`ChannelManager::abandon_payment`] to abandon the associated payment. See those docs for
 	/// further details.
@@ -834,7 +834,7 @@ pub enum Event {
 	///
 	/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
 	/// [`Refund`]: crate::offers::refund::Refund
-	/// [`UserConfig::manually_handle_bolt12_invoices`]: crate::util::config::UserConfig::manually_handle_bolt12_invoices
+	/// [`UserConfig::manually_handle_bolt12_messages`]: crate::util::config::UserConfig::manually_handle_bolt12_messages
 	/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
 	/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
 	InvoiceReceived {

lightning/src/ln/channelmanager.rs

@@ -11154,7 +11154,7 @@ where
 					&self.logger, None, None, Some(invoice.payment_hash()),
 				);
 
-				if self.default_configuration.manually_handle_bolt12_invoices {
+				if self.default_configuration.manually_handle_bolt12_messages {
 					let event = Event::InvoiceReceived {
 						payment_id, invoice, context, responder,
 					};

lightning/src/ln/offers_tests.rs

@@ -1146,7 +1146,7 @@ fn creates_and_pays_for_offer_with_retry() {
 #[test]
 fn pays_bolt12_invoice_asynchronously() {
 	let mut manually_pay_cfg = test_default_channel_config();
-	manually_pay_cfg.manually_handle_bolt12_invoices = true;
+	manually_pay_cfg.manually_handle_bolt12_messages = true;
 
 	let chanmon_cfgs = create_chanmon_cfgs(2);
 	let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);

lightning/src/util/config.rs

@@ -859,7 +859,7 @@ pub struct UserConfig {
 	/// [`Event::InvoiceReceived`]: crate::events::Event::InvoiceReceived
 	/// [`ChannelManager::send_payment_for_bolt12_invoice`]: crate::ln::channelmanager::ChannelManager::send_payment_for_bolt12_invoice
 	/// [`ChannelManager::abandon_payment`]: crate::ln::channelmanager::ChannelManager::abandon_payment
-	pub manually_handle_bolt12_invoices: bool,
+	pub manually_handle_bolt12_messages: bool,
 }
 
 impl Default for UserConfig {
@@ -873,7 +873,7 @@ impl Default for UserConfig {
 			manually_accept_inbound_channels: false,
 			accept_intercept_htlcs: false,
 			accept_mpp_keysend: false,
-			manually_handle_bolt12_invoices: false,
+			manually_handle_bolt12_messages: false,
 		}
 	}
 }
@@ -893,7 +893,7 @@ impl Readable for UserConfig {
 			manually_accept_inbound_channels: Readable::read(reader)?,
 			accept_intercept_htlcs: Readable::read(reader)?,
 			accept_mpp_keysend: Readable::read(reader)?,
-			manually_handle_bolt12_invoices: Readable::read(reader)?,
+			manually_handle_bolt12_messages: Readable::read(reader)?,
 		})
 	}
 }