f: Remove spurious _persistence_guard check

shaavan · shaavan · commit 3871ea13613c · 2024-12-11T17:46:41.000+05:30
- The _persistence_guard here was not serving any purpose, and hence can
  be removed in this refactoring.
diff --git a/lightning/src/offers/flow.rs b/lightning/src/offers/flow.rs
@@ -1162,9 +1162,6 @@ where
 			return Err(Bolt12SemanticError::UnsupportedChain);
 		}
 
-		// TODO: Add persistance through `commons` internal function. Shouldn't be exposed here.
-		// let _persistence_guard = PersistenceNotifierGuard::notify_on_drop(&*self.commons);
-
 		match self.commons.create_inbound_payment(Some(amount_msats), relative_expiry, None) {
 			Ok((payment_hash, payment_secret)) => {
 				let payment_context = PaymentContext::Bolt12Refund(Bolt12RefundContext {});

Original file line number	Diff line number	Diff line change
`@@ -1162,9 +1162,6 @@ where`
`1162`	`1162`	`return Err(Bolt12SemanticError::UnsupportedChain);`
`1163`	`1163`	`}`
`1164`	`1164`
`1165`		- // TODO: Add persistance through `commons` internal function. Shouldn't be exposed here.
`1166`		`- // let _persistence_guard = PersistenceNotifierGuard::notify_on_drop(&*self.commons);`
`1167`		`-`
`1168`	`1165`	`match self.commons.create_inbound_payment(Some(amount_msats), relative_expiry, None) {`
`1169`	`1166`	`Ok((payment_hash, payment_secret)) => {`
`1170`	`1167`	`let payment_context = PaymentContext::Bolt12Refund(Bolt12RefundContext {});`