Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Longs parsed as int when compared #604

Open
Eufranio opened this issue Dec 6, 2018 · 3 comments
Open

Longs parsed as int when compared #604

Eufranio opened this issue Dec 6, 2018 · 3 comments

Comments

@Eufranio
Copy link

Eufranio commented Dec 6, 2018

Detailed ticket here: SpongePowered/Configurate#127

Long numbers are parsed as integers when being compared, and throw a NumberFormatException.
@havocp
Copy link
Collaborator

havocp commented Dec 6, 2018

PR in progress #568 well linking to another PR also in progress #557

@Eufranio
Copy link
Author

Eufranio commented Dec 6, 2018

Okay. Any ETA?

@havocp
Copy link
Collaborator

havocp commented Dec 6, 2018

The library doesn't have any deterministic or funded maintenance unfortunately. But I did add a review note to #568 just now. I think pulling the BigInteger approach into #568 from #557 would be easy to merge.

@zachbr zachbr mentioned this issue Jan 2, 2019
Closed
michalmela added a commit to michalmela/config that referenced this issue Jan 4, 2019
@michalmela @michalmela-tomtom
Fixed support for keys that are all digits but longer than an int.
baaa9c8 
Previously such config keys would still be parsed with
`Integer#parseInt` for the sake of sorting, resulting in a `NumberFormatException`.
Now the keys consisting of digits only are parsed to a `BigInteger` and
compared as such.

This addresses the following issues:
lightbend#604
lightbend#541
michalmela added a commit to michalmela/config that referenced this issue Jan 8, 2019
@michalmela @michalmela-tomtom
Fixed support for keys that are all digits but longer than an int.
fee9a3e 
Previously such config keys would still be parsed with
`Integer#parseInt` for the sake of sorting, resulting in a `NumberFormatException`.
Now the keys consisting of digits only are parsed to a `BigInteger` and
compared as such.

This addresses the following issues:
lightbend#604
lightbend#541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@havocp @Eufranio