Skip to content

Conversation

Copy link

Copilot AI commented Nov 12, 2025

Responded to review feedback requesting naming suggestions for the call method in IStrategyCallForwarder.

Recommendation

Rename callfunctionCall to:

  • Align with OpenZeppelin's Address.functionCall (used internally)
  • Avoid confusion with Solidity's low-level .call()
  • Enable consistent pairing with callWithValuefunctionCallWithValue
// Current usage
IStrategyCallForwarder(callForwarder)
    .call(address(WSTETH), abi.encodeWithSelector(WSTETH.approve.selector, ...));

// Proposed
IStrategyCallForwarder(callForwarder)
    .functionCall(address(WSTETH), abi.encodeWithSelector(WSTETH.approve.selector, ...));

Awaiting confirmation to proceed with renaming across interface, implementation, and all call sites.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Nov 12, 2025
Copilot AI changed the title [WIP] Update method naming in GGV wsteth based on review Provide naming recommendation for IStrategyCallForwarder.call method Nov 12, 2025
Copilot AI requested a review from avsetsin November 12, 2025 08:58
Copilot finished work on behalf of avsetsin November 12, 2025 08:58
@arwer13
Copy link
Contributor

arwer13 commented Nov 12, 2025

maybe doCall?

@avsetsin avsetsin closed this Nov 12, 2025
@avsetsin avsetsin deleted the copilot/sub-pr-49 branch November 12, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants