feat: notify module on boost config changes

Author: skhomuti

src/ERC20LockBoostProvider.sol

@@ -108,6 +108,7 @@ contract ERC20LockBoostProvider is Initializable, AccessControlEnumerableUpgrade
         }
 
         emit LockBoostStepsSet(steps);
+        META_REGISTRY.notifyWeightBoostProviderConfigChanged();
     }
 
     /// @inheritdoc IERC20LockBoostProvider

src/MetaRegistry.sol

@@ -152,7 +152,7 @@ contract MetaRegistry is IMetaRegistry, Initializable, AccessControlEnumerableUp
 
         $.bondCurveWeight[curveId] = weight;
         emit BondCurveWeightSet(curveId, weight);
-        MODULE.requestFullDepositInfoUpdate();
+        _requestFullDepositInfoUpdate();
     }
 
     /// @inheritdoc IMetaRegistry
@@ -176,6 +176,7 @@ contract MetaRegistry is IMetaRegistry, Initializable, AccessControlEnumerableUp
         });
         $.weightBoostProviderIdByAddress[providerAddr] = providerId;
         emit WeightBoostProviderAdded(providerAddr, mode);
+        _requestFullDepositInfoUpdate();
     }
 
     /// @inheritdoc IMetaRegistry
@@ -193,6 +194,7 @@ contract MetaRegistry is IMetaRegistry, Initializable, AccessControlEnumerableUp
 
         entry.enabled = enabled;
         emit WeightBoostProviderEnabledSet(providerAddr, enabled);
+        _requestFullDepositInfoUpdate();
     }
 
     /// @inheritdoc IMetaRegistry
@@ -214,6 +216,7 @@ contract MetaRegistry is IMetaRegistry, Initializable, AccessControlEnumerableUp
         --$.weightBoostProvidersCount;
 
         emit WeightBoostProviderRemoved(providerAddr);
+        _requestFullDepositInfoUpdate();
     }
 
     /// @inheritdoc IMetaRegistry
@@ -230,6 +233,18 @@ contract MetaRegistry is IMetaRegistry, Initializable, AccessControlEnumerableUp
         _refreshGroupWeights(groupId);
     }
 
+    /// @inheritdoc IMetaRegistry
+    function notifyWeightBoostProviderConfigChanged() external {
+        MetaRegistryStorage storage $ = _storage();
+        uint256 providerId = $.weightBoostProviderIdByAddress[msg.sender];
+        if (providerId == 0) return;
+
+        if (!$.weightBoostProviders[providerId].enabled) return;
+
+        emit WeightBoostProviderConfigChanged(msg.sender);
+        _requestFullDepositInfoUpdate();
+    }
+
     /// @inheritdoc IMetaRegistry
     function notifyWeightBoostChanged(uint256 nodeOperatorId) external {
         MetaRegistryStorage storage $ = _storage();
@@ -522,6 +537,10 @@ contract MetaRegistry is IMetaRegistry, Initializable, AccessControlEnumerableUp
         MODULE.notifyNodeOperatorWeightChange(nodeOperatorId, oldWeight, newWeight);
     }
 
+    function _requestFullDepositInfoUpdate() internal {
+        MODULE.requestFullDepositInfoUpdate();
+    }
+
     function _storeOperatorMetadata(uint256 nodeOperatorId, OperatorMetadata memory metadata) internal {
         if (bytes(metadata.name).length > MAX_NAME_LENGTH) revert OperatorNameTooLong();
         if (bytes(metadata.description).length > MAX_DESCRIPTION_LENGTH) revert OperatorDescriptionTooLong();

src/interfaces/IERC20LockBoostProvider.sol

@@ -78,7 +78,7 @@ interface IERC20LockBoostProvider is IWeightBoostProvider {
     /// @param steps Ordered lock amount thresholds with boost in basis points.
     /// @dev Each step applies from minAmount inclusive until the next step minAmount.
     ///      Existing weights are not refreshed by this call;
-    ///      refresh affected operators explicitly in MetaRegistry.
+    ///      a full deposit info update is requested via MetaRegistry.
     ///      Disable the boost provider in MetaRegistry to turn off the configured boosts.
     function setLockBoostSteps(LockBoostStep[] calldata steps) external;
 

src/interfaces/IMetaRegistry.sol

@@ -50,6 +50,7 @@ interface IMetaRegistry {
     event WeightBoostProviderAdded(address indexed provider, WeightBoostProviderMode mode);
     event WeightBoostProviderRemoved(address indexed provider);
     event WeightBoostProviderEnabledSet(address indexed provider, bool enabled);
+    event WeightBoostProviderConfigChanged(address indexed provider);
     event GroupWeightsRefreshed(uint256 indexed groupId);
     event OperatorMetadataSet(uint256 indexed nodeOperatorId, OperatorMetadata metadata);
     event NodeOperatorEffectiveWeightChanged(uint256 indexed nodeOperatorId, uint256 oldWeight, uint256 newWeight);
@@ -184,22 +185,22 @@ interface IMetaRegistry {
 
     /// @notice Add a weight boost provider.
     /// @dev Adding a provider is expected to be a rare operation and does not refresh cached weights automatically.
-    ///      Affected groups must be refreshed asynchronously via refreshGroupWeights().
+    ///      A full deposit info update is requested and affected groups must be refreshed asynchronously.
     ///      Added providers are enabled by default.
     /// @param provider Boost provider consumed during weight calculation.
     /// @param mode Provider aggregation mode.
     function addWeightBoostProvider(IWeightBoostProvider provider, WeightBoostProviderMode mode) external;
 
     /// @notice Enable or disable a weight boost provider.
     /// @dev Enabling or disabling a provider does not refresh cached weights automatically.
-    ///      Affected groups must be refreshed asynchronously via refreshGroupWeights().
+    ///      A full deposit info update is requested and affected groups must be refreshed asynchronously.
     /// @param provider Boost provider to update.
     /// @param enabled Whether the provider should participate in weight calculations.
     function setWeightBoostProviderEnabled(IWeightBoostProvider provider, bool enabled) external;
 
     /// @notice Remove a weight boost provider.
     /// @dev Removing a provider is expected to be a rare operation and does not refresh cached weights automatically.
-    ///      Affected groups must be refreshed asynchronously via refreshGroupWeights().
+    ///      A full deposit info update is requested and affected groups must be refreshed asynchronously.
     /// @param provider Boost provider to remove.
     function removeWeightBoostProvider(IWeightBoostProvider provider) external;
 
@@ -236,10 +237,15 @@ interface IMetaRegistry {
     /// @notice Trigger the group weight update routine in the registry.
     /// @param groupId Operator group ID to trigger the update for.
     /// @dev Use this after asynchronous provider configuration changes such as addWeightBoostProvider(),
-    ///      setWeightBoostProviderEnabled(), and removeWeightBoostProvider().
+    ///      notifyWeightBoostProviderConfigChanged(), setWeightBoostProviderEnabled(), and removeWeightBoostProvider().
     function refreshGroupWeights(uint256 groupId) external;
 
     /// @notice Notify the registry that a configured provider changed a node operator boost.
     /// @param nodeOperatorId Node operator ID whose provider boost changed.
     function notifyWeightBoostChanged(uint256 nodeOperatorId) external;
+
+    /// @notice Notify the registry that a configured provider changed global boost parameters.
+    /// @dev Requests a full deposit info update when the sender is an enabled provider.
+    ///      Unregistered or disabled providers are ignored since cached weights do not depend on them.
+    function notifyWeightBoostProviderConfigChanged() external;
 }

test/unit/ERC20LockBoostProvider.t.sol

@@ -409,6 +409,10 @@ contract ERC20LockBoostProviderAdminTest is ERC20LockBoostProviderBaseTest {
 
         vm.expectEmit(address(provider));
         emit IERC20LockBoostProvider.LockBoostStepsSet(steps);
+        vm.expectCall(
+            address(registry),
+            abi.encodeWithSelector(IMetaRegistry.notifyWeightBoostProviderConfigChanged.selector)
+        );
         vm.prank(admin);
         provider.setLockBoostSteps(steps);
 

test/unit/MetaRegistry.t.sol

@@ -1123,6 +1123,7 @@ contract MetaRegistryWeightBoostProviderTest is MetaRegistryGroupsBaseTest {
 
         provider.mock_setBoostBP(0, 1000);
 
+        vm.expectCall(address(module), abi.encodeWithSelector(IBaseModule.requestFullDepositInfoUpdate.selector));
         vm.expectEmit(address(registry));
         emit IMetaRegistry.WeightBoostProviderAdded(address(provider), NODE_OPERATOR_MODE);
         vm.prank(admin);
@@ -1156,6 +1157,7 @@ contract MetaRegistryWeightBoostProviderTest is MetaRegistryGroupsBaseTest {
         secondProvider.mock_setBoostBP(0, 1000);
         secondProvider.mock_setBoostBP(1, 2000);
 
+        vm.expectCall(address(module), abi.encodeWithSelector(IBaseModule.requestFullDepositInfoUpdate.selector));
         vm.expectEmit(address(registry));
         emit IMetaRegistry.WeightBoostProviderAdded(address(secondProvider), GROUP_MAX_MODE);
         vm.prank(admin);
@@ -1206,6 +1208,7 @@ contract MetaRegistryWeightBoostProviderTest is MetaRegistryGroupsBaseTest {
         assertEq(registry.getNodeOperatorWeight(0), 11000);
 
         vm.startPrank(admin);
+        vm.expectCall(address(module), abi.encodeWithSelector(IBaseModule.requestFullDepositInfoUpdate.selector));
         vm.expectEmit(address(registry));
         emit IMetaRegistry.WeightBoostProviderRemoved(address(provider));
         registry.removeWeightBoostProvider(provider);
@@ -1258,6 +1261,7 @@ contract MetaRegistryWeightBoostProviderTest is MetaRegistryGroupsBaseTest {
         registry.refreshGroupWeights(groupId);
         assertEq(registry.getNodeOperatorWeight(0), 11000);
 
+        vm.expectCall(address(module), abi.encodeWithSelector(IBaseModule.requestFullDepositInfoUpdate.selector));
         vm.expectEmit(address(registry));
         emit IMetaRegistry.WeightBoostProviderEnabledSet(address(provider), false);
         vm.prank(admin);
@@ -1283,6 +1287,7 @@ contract MetaRegistryWeightBoostProviderTest is MetaRegistryGroupsBaseTest {
         _createGroup(_subOperatorsArr1(0, MAX_BP), _extOperatorsArr0());
         assertEq(registry.getNodeOperatorWeight(0), CURVE_WEIGHT);
 
+        vm.expectCall(address(module), abi.encodeWithSelector(IBaseModule.requestFullDepositInfoUpdate.selector));
         vm.expectEmit(address(registry));
         emit IMetaRegistry.WeightBoostProviderEnabledSet(address(provider), true);
         vm.prank(admin);
@@ -1367,6 +1372,44 @@ contract MetaRegistryWeightBoostProviderTest is MetaRegistryGroupsBaseTest {
         assertEq(registry.getNodeOperatorWeight(0), CURVE_WEIGHT);
     }
 
+    function test_notifyWeightBoostProviderConfigChanged_RequestsFullDepositInfoUpdate() public {
+        vm.prank(admin);
+        registry.addWeightBoostProvider(provider, NODE_OPERATOR_MODE);
+
+        vm.expectCall(address(module), abi.encodeWithSelector(IBaseModule.requestFullDepositInfoUpdate.selector));
+        vm.expectEmit(address(registry));
+        emit IMetaRegistry.WeightBoostProviderConfigChanged(address(provider));
+        vm.prank(address(provider));
+        registry.notifyWeightBoostProviderConfigChanged();
+    }
+
+    function test_notifyWeightBoostProviderConfigChanged_NoOpWhenProviderNotFound() public {
+        vm.mockCallRevert(
+            address(module),
+            abi.encodeWithSelector(IBaseModule.requestFullDepositInfoUpdate.selector),
+            abi.encode("UNEXPECTED_REQUEST_FULL_DEPOSIT_INFO_UPDATE")
+        );
+
+        vm.prank(address(provider));
+        registry.notifyWeightBoostProviderConfigChanged();
+    }
+
+    function test_notifyWeightBoostProviderConfigChanged_NoOpWhenProviderDisabled() public {
+        vm.startPrank(admin);
+        registry.addWeightBoostProvider(provider, NODE_OPERATOR_MODE);
+        registry.setWeightBoostProviderEnabled(provider, false);
+        vm.stopPrank();
+
+        vm.mockCallRevert(
+            address(module),
+            abi.encodeWithSelector(IBaseModule.requestFullDepositInfoUpdate.selector),
+            abi.encode("UNEXPECTED_REQUEST_FULL_DEPOSIT_INFO_UPDATE")
+        );
+
+        vm.prank(address(provider));
+        registry.notifyWeightBoostProviderConfigChanged();
+    }
+
     function test_createAndUpdateGroup_RecalculatesGroupMaxFromComposition() public {
         _setBondCurveWeight(0, CURVE_WEIGHT);
         provider.mock_setBoostBP(0, 1000);