We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a remote peer provides a public key in an identify message that doesn't match their peer ID, it's not specified how it should be handled.
identify
Potentially the connection could be closed since this shouldn't happen unless the remote peer is misconfigured/malicious (discussion at libp2p/rust-libp2p#5713 / libp2p/rust-libp2p#5707 (comment))
We could add something to the spec (https://github.com/libp2p/specs/tree/master/identify#publickey) like:
If a remote peer provides a public key which doesn't match their peer ID, the receiving node SHOULD close the connection.
So existing implementations which don't do this would still match the v1.0.0 spec.
The text was updated successfully, but these errors were encountered:
That seems reasonable. We currently ignore this in go-libp2p
Sorry, something went wrong.
No branches or pull requests
If a remote peer provides a public key in an
identify
message that doesn't match their peer ID, it's not specified how it should be handled.Potentially the connection could be closed since this shouldn't happen unless the remote peer is misconfigured/malicious (discussion at libp2p/rust-libp2p#5713 / libp2p/rust-libp2p#5707 (comment))
We could add something to the spec (https://github.com/libp2p/specs/tree/master/identify#publickey) like:
So existing implementations which don't do this would still match the v1.0.0 spec.
The text was updated successfully, but these errors were encountered: