Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpr::LowSpeed Is Not Y2038 Safe #1174

Open
COM8 opened this issue Feb 8, 2025 · 0 comments
Open

cpr::LowSpeed Is Not Y2038 Safe #1174

COM8 opened this issue Feb 8, 2025 · 0 comments
Labels

Comments

@COM8
Copy link
Member

COM8 commented Feb 8, 2025

Description

cpr::LowSpeed has a 32 bit time value (std::int32_t time;). This is not year 2038 safe. Instead we should replace it with std::chrono for handling time.
Even though it's just the seconds and probably will never happen we should use std::chrono.

Example/How to Reproduce

Not applicable.

Possible Fix

Refactor cpr::LowSpeed to use std::chrono.

Where did you get it from?

GitHub (branch e.g. master)

Additional Context/Your Environment

  • OS: Linux (Fedora 41)
  • Version: 1.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant