You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some methods we take a pointer to a parser that's already created (e.g. ChemicalMixture constructor). Others, we don't give that option and construct the parser internally (e.g. `read_reaction_set_data1). It would be nice for the user to instantiate one parser object and use it everywhere, if appropriate.
The text was updated successfully, but these errors were encountered:
There are some methods that live in global namespace, e.g. read_reaction_set_data, that should be in ParserBase and then calls methods that can be implemented in subclasses. This is once example. We definitely want to consolidate all these because the parsing is spread out everywhere making it really hard to follow.
pbauman
changed the title
Consistency in Parsing Methods
Consistency/Consolidation in Parsing Methods
Jun 26, 2018
Some methods we take a pointer to a parser that's already created (e.g.
ChemicalMixture
constructor). Others, we don't give that option and construct the parser internally (e.g. `read_reaction_set_data1). It would be nice for the user to instantiate one parser object and use it everywhere, if appropriate.The text was updated successfully, but these errors were encountered: