Potential bug in FParser JIT conditionals

[dschwen]

I might have accidentally swapped the conditionals for If and AbsIf... oops.

libmesh/contrib/fparser/fparser_ad.cc

Lines 991 to 994 in c024b0a

	if (op == cIf)
	ccout << "if (std::abs(s[" << sp-- << "]) < 0.5) ";
	if (op == cAbsIf)
	ccout << "if (s[" << sp-- << "] < 0.5) ";

[jwpeterson]

@dschwen is this just a one-line fix? If I'm reading the git logs correctly, it looks like the bug has been there since 0dfbd62 (2014!) so it's kind of surprising that no one encountered it in the intervening years, no?

[dschwen]

kind of surprising that no one encountered it in the intervening years

Yeah, it is, but then again I don't know how often this opcode is emitted. There is no explicit way to generate it from a parsed expression. I suspect FPOptimizer uses it. And yes, that's a one line fix.