Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating-Point Comparisons without Tolerance in mesh_triangle_holes.C #3496

Open
miaoyinb opened this issue Mar 15, 2023 · 0 comments · May be fixed by #3497
Open

Floating-Point Comparisons without Tolerance in mesh_triangle_holes.C #3496

miaoyinb opened this issue Mar 15, 2023 · 0 comments · May be fixed by #3497

Comments

@miaoyinb
Copy link
Contributor

The find_intersection() function in mesh_triangle_holes.C contains a number of floating-point comparisons without tolerance. The function is used by MOOSE's XYDelaunayGenerator through libMesh::TriangulatorInterface::Hole::find_ray_intersections() to verify the holes/boundary geometry. And these floating-point comparisons without tolerance sometimes cause "false positive error" in such verification.
miaoyinb added a commit to miaoyinb/libmesh that referenced this issue Mar 15, 2023
@miaoyinb
Add Tolerance to Floating Point Comparisons in find_intersection()
30c1237 
closes libMesh#3496
@miaoyinb miaoyinb linked a pull request Mar 15, 2023 that will close this issue
Open
miaoyinb added a commit to miaoyinb/libmesh that referenced this issue May 2, 2023
@miaoyinb
Add Tolerance to Floating Point Comparisons in find_intersection()
3767c48 
closes libMesh#3496
miaoyinb added a commit to miaoyinb/libmesh that referenced this issue Jun 21, 2023
@miaoyinb
Add Tolerance to Floating Point Comparisons in find_intersection()
2a4f66a 
closes libMesh#3496
miaoyinb added a commit to miaoyinb/libmesh that referenced this issue Jun 22, 2023
@miaoyinb
add random shifts to find_intersection()
0197257 
closes libMesh#3496
@miaoyinb miaoyinb mentioned this issue Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Tolerance to Floating Point Comparisons in find_intersection() miaoyinb/libmesh
1 participant
@miaoyinb