Assertion failed in coroutine

[scallaway]

Description

This is very similar to #814, but happening in a slightly different part of hunks.lua.

I can't work out quite when this crash happens, but I've found it to happen pretty consistently in a Python file that is open for a minute or so. Of course when the error shows, the git signs completely vanish.

---

I had a run through the hunks.lua file and found the assert thats failing. I commented it out and had a play around with the minimum config again and that seems to do the job, but I can't be sure that's not absolutely required in the plugin.

Neovim version

nightly

Operating system and version

debian

Expected behavior

No response

Actual behavior

Error output is the following;

Error executing vim.schedule lua callback: ...gitsigns_issue/gitsigns//lua/gitsigns/async.lua:76: The coroutine failed with this message: ...gitsigns_issue/gitsigns//lua/gitsigns/hunks.lua:172: assertion failed!
stack traceback:
        [C]: in function 'assert'
        ...gitsigns_issue/gitsigns//lua/gitsigns/hunks.lua:172: in function 'calc_signs'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:59: in function 'apply_win_signs0'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:81: in function 'apply_win_signs'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:454: in function 'fn'
        ...tform/gitsigns_issue/gitsigns//lua/gitsigns/debounce.lua:76: in function 'update'
        ...gitsigns_issue/gitsigns//lua/gitsigns/watcher.lua:88: in function <...gitsigns_issue/gitsigns//lua/gitsigns/watcher.lua:59>
stack traceback:
        [C]: in function 'error'
        ...gitsigns_issue/gitsigns//lua/gitsigns/async.lua:76: in function 'cb'
        ...gitsigns_issue/gitsigns//lua/gitsigns/async.lua:113: in function 'cb'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:36: in function <...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:34>

Minimal config

for name, url in pairs({
	gitsigns = "https://github.com/lewis6991/gitsigns.nvim",
	-- ADD OTHER PLUGINS _NECESSARY_ TO REPRODUCE THE ISSUE
	nvim_lspconfig = "https://github.com/neovim/nvim-lspconfig",
}) do
	local install_path = vim.fn.fnamemodify("gitsigns_issue/" .. name, ":p")
	if vim.fn.isdirectory(install_path) == 0 then
		vim.fn.system({ "git", "clone", "--depth=1", url, install_path })
	end
	vim.opt.runtimepath:append(install_path)
end

require("gitsigns").setup({
	debug_mode = true, -- You must add this to enable debug messages
	-- ADD GITSIGNS CONFIG THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE
})

-- ADD INIT.LUA SETTINGS THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE

require("lspconfig").pyright.setup({})

Steps to reproduce

1. nvim --clean -u minimal.lua
2. Wait for a little bit

Gitsigns debug messages

No response

[lewis6991]

I improved the assertion message in 61e50f3. Can you report the message when it happens again.

[scallaway]

Error executing vim.schedule lua callback: ...gitsigns_issue/gitsigns//lua/gitsigns/async.lua:76: The coroutine failed with this message: ...gitsigns_issue/gitsigns//lua/gitsigns/hunks.lua:172: Invalid hunk with untracked=true hunk="@@ -2308,1 +2308,3 @@"

stack traceback:
        [C]: in function 'assert'
        ...gitsigns_issue/gitsigns//lua/gitsigns/hunks.lua:172: in function 'calc_signs'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:59: in function 'apply_win_signs0'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:81: in function 'apply_win_signs'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:454: in function 'fn'
        ...tform/gitsigns_issue/gitsigns//lua/gitsigns/debounce.lua:76: in function 'update'
        ...gitsigns_issue/gitsigns//lua/gitsigns/watcher.lua:88: in function <...gitsigns_issue/gitsigns//lua/gitsigns/watcher.lua:59>
stack traceback:
        [C]: in function 'error'
        ...gitsigns_issue/gitsigns//lua/gitsigns/async.lua:76: in function 'cb'
        ...gitsigns_issue/gitsigns//lua/gitsigns/async.lua:113: in function 'cb'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:36: in function <...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:34>
Error in decoration provider gitsigns.win:
Error executing lua: ...gitsigns_issue/gitsigns//lua/gitsigns/hunks.lua:172: Invalid hunk with untracked=true hunk="@@ -2308,1 +2308,3 @@"
stack traceback:
        [C]: in function 'assert'
        ...gitsigns_issue/gitsigns//lua/gitsigns/hunks.lua:172: in function 'calc_signs'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:63: in function 'apply_win_signs0'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:81: in function 'apply_win_signs'
        ...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:511: in function <...gitsigns_issue/gitsigns//lua/gitsigns/manager.lua:502>

That's what I get on the latest version of gitsigns

[scallaway]

For what it's worth, that's editing the same file that I was recreating the issue on earlier. It's a file that already exists in source control and I've just updated some lines (edited a few, added a few).

The line 2308 that it's outputting there is a line that I've edited.

[lewis6991]

Gitsigns doesn't think this file is maintained in git for whatever reason (due to untracked=true).

This will come from when Gitsigns run git ls-files <filename> and then determines whether the file is tracked based on the result. You would have seen this in the debug messages, however this hasn't been provided in the issue report.

[scallaway]

Gitsigns doesn't think this file is maintained in git for whatever reason

Hmm that's strange, do you believe it's not an issue with gitsigns then?

You would have seen this in the debug messages, however this hasn't been provided in the issue report.

So I can see that git ls-files is being called, but I can't see in :Gitsigns debug_messages whether there is a problem with the output or not.

---

Also, just realised that I didn't include this in the first issue, but I can recreate this very easily when I have to separate files open in two panes (split vertically but I haven't tried any other way).

[lewis6991]

It could be, but it's hard to tell. There could be a race condition.

Without a reliable way to repro this, I'm not sure what to suggest.

[alligatortower]

From casual observation this error seems to happen to me when switching out of (or perhaps back to) the tmux tab where I'm running neovim. If it's the result of something I'm doing while tabbed away, I haven't noticed a pattern. It's extremely intermittent in all cases.

[mosheavni]

happens to me frequently as well

[astutecat]

I tend to see this issue happen when I do some git-related calls outside of nvim in another tmux window - for example reverting changes or some other index-based operations.

If you use stacked git, it appears to happen a lot if you use it to insert changes into another commit -- this operation presumably involves rapidly stashing/reverting and re-applying of changes.

[scallaway]

I tend to see this issue happen when I do some git-related calls outside of nvim in another tmux window

This is interesting.

I do use Lazygit in another tmux window, so that might be affecting it.

I'm going to run a temporary branch (https://github.com/scallaway/gitsigns.nvim/tree/temp-fix-assertion) for a while to see if anything else badly breaks. Given as far as I can tell that's the line that is complaining the entire time.

[astutecat]

using lazygit and doing reverts, stashes ... something like that where the index changes seems to trigger it. Some kind of 'rug-pull' where the file goes from being in a modified state to not?

[lewis6991]

I just want to point out no one has yet to provide the output of debug messages when this error occurs. The debug messages should indicate what commands for each buffer is being issued as well as whenever the gitdir watcher triggers.

[lewis6991]

I don't know if this will fix the issue but #869 should fix some related problems around certain kinds of 'rug-pulls'.

I would appreciate if anyone facing this issue could test this and report back.

[scallaway]

I just want to point out no one has yet to provide the output of debug messages when this error occurs.

I've just pulled the following logs out now that I've been able to see it happen a few times. Note that file names are redacted.

-- Console error --
Error executing vim.schedule lua callback: ...e/pack/packer/start/gitsigns.nvim/lua/gitsigns/async.lua:76: The coroutine failed with this message: ...e/pack/packer/start/gitsigns.nvim/lua/gitsigns/hunks.lua:172: Invalid hunk with untracked=true hunk="@@ -16,1 +16,1 @@"
stack traceback:
        [C]: in function 'assert'
        ...e/pack/packer/start/gitsigns.nvim/lua/gitsigns/hunks.lua:172: in function 'calc_signs'
        ...pack/packer/start/gitsigns.nvim/lua/gitsigns/manager.lua:50: in function 'apply_win_signs0'
        ...pack/packer/start/gitsigns.nvim/lua/gitsigns/manager.lua:72: in function 'apply_win_signs'
        ...pack/packer/start/gitsigns.nvim/lua/gitsigns/manager.lua:445: in function 'fn'
        ...ack/packer/start/gitsigns.nvim/lua/gitsigns/debounce.lua:76: in function 'update'
        ...pack/packer/start/gitsigns.nvim/lua/gitsigns/watcher.lua:103: in function <...pack/packer/start/gitsigns.nvim/lua/gitsigns/watcher.lua:77>
stack traceback:
        [C]: in function 'error'
        ...e/pack/packer/start/gitsigns.nvim/lua/gitsigns/async.lua:76: in function 'cb'
        ...e/pack/packer/start/gitsigns.nvim/lua/gitsigns/async.lua:113: in function 'cb'
        ...e/pack/packer/start/gitsigns.nvim/lua/gitsigns/async.lua:186: in function <...e/pack/packer/start/gitsigns.nvim/lua/gitsigns/async.lua:184>
Press ENTER or type command to continue

-- Debug messages --

cli.run: Running action 'debug_messages' with arguments {}
watcher_cb(1): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(72): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(74): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(93): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(96): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(30): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(198): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(44): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(201): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(217): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(255): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(1): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(72): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(74): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(93): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(96): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(198): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(44): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(201): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(217): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(255): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(1): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(72): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(74): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(93): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(96): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(30): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(198): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(44): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(201): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(217): Git dir update: 'FETCH_HEAD' { change = true }
watcher_cb(255): Git dir update: 'FETCH_HEAD' { change = true }
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.ts
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.ts
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.ts
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git -c core.quotepath=off ls-files --stage --others --exclude-standard --eol working_dir/*.py

run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.ts
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.ts
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.ts
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.tsx
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir working_dir.git show :0:*.py
update(1): updates: 3746, jobs: 5644
update(72): updates: 3747, jobs: 5644
update(74): updates: 3748, jobs: 5644
update(93): updates: 3749, jobs: 5644
update(96): updates: 3750, jobs: 5644
update(198): updates: 3751, jobs: 5644
update(44): updates: 3752, jobs: 5644
update(201): updates: 3753, jobs: 5644
update(217): updates: 3754, jobs: 5644
update(255): updates: 3755, jobs: 5644
cli.run: Running action 'dump_cache' with arguments {}
cli.run: Running action 'debug_messages' with arguments {}

For context, this only seems to happen in the pane that contains a Python file. I had two vertical panes setup, one with a JSX file and one with a Python file. I can't remember which one was focused (as I was tabbed out).