Skip to content

Rate limits incorrect after overridden until next TAT #8785

@mcpherrinm

Description

@mcpherrinm

Since we switched to GCRA, we've had a bug in our rate limits when an override changes.

We don't update the TAT until the next successful issuance, so when increasing a rate-limit, we'll continue to deny until we reach that TAT, and we'll return an incorrect error message that says you've exceeded your new rate limit when you've actually exceeded the old rate limit.

This can be particularly confusing if you've had a rate limit increase, and our error messages tell you that you've already exceeded the new limit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions