From 1192d25b5dba6e46775254ce1b751ee4d8b4724c Mon Sep 17 00:00:00 2001 From: arkrak <44460504+arkrak@users.noreply.github.com> Date: Fri, 26 Oct 2018 21:06:57 +0800 Subject: [PATCH 1/3] index.js Removed comments --- examples/cloud-data-storage-client-poc/index.js | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/examples/cloud-data-storage-client-poc/index.js b/examples/cloud-data-storage-client-poc/index.js index d12223a..e17034e 100644 --- a/examples/cloud-data-storage-client-poc/index.js +++ b/examples/cloud-data-storage-client-poc/index.js @@ -1,6 +1,3 @@ -/** - * Before running this file make sure GOOGLE_APPLICATION_CREDENTIALS variable is set - */ const Storage = require('@google-cloud/storage'); const gcs = new Storage(); @@ -11,7 +8,7 @@ gcs.interceptors.push({ 'https://www.googleapis.com', 'http://localhost:8080' ); - // console.log(JSON.stringify(reqOpts)); + return reqOpts; }, }); @@ -24,10 +21,6 @@ gcs const bucket = await gcs.bucket('test-bucket').get(); - // this endpoint doesn't work correctly - // const uploadRes = await gcs.bucket('test-bucket').upload('./test.txt'); - - // await gcs.bucket('test-bucket').delete(); } catch (err) { console.log(`${err.message}`); } From 2ee809c5d08c8221181cd8d9315819a32d726927 Mon Sep 17 00:00:00 2001 From: arkrak <44460504+arkrak@users.noreply.github.com> Date: Fri, 26 Oct 2018 21:09:37 +0800 Subject: [PATCH 2/3] Dockerfile Removed comments --- src/services/cloud-functions/Dockerfile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/services/cloud-functions/Dockerfile b/src/services/cloud-functions/Dockerfile index 4bd5508..fa77be3 100644 --- a/src/services/cloud-functions/Dockerfile +++ b/src/services/cloud-functions/Dockerfile @@ -1,6 +1,5 @@ FROM node:6.11-slim -# Create app directory WORKDIR /usr/src/app RUN npm install -g @google-cloud/functions-emulator @@ -11,4 +10,4 @@ RUN mkdir /functions COPY config.json /root/.config/configstore/@google-cloud/functions-emulator/config.json -CMD ["functions", "start", "--tail"] \ No newline at end of file +CMD ["functions", "start", "--tail"] From 7589625bfc778297c7f0886af834b66fc207b7b7 Mon Sep 17 00:00:00 2001 From: arkrak <44460504+arkrak@users.noreply.github.com> Date: Fri, 26 Oct 2018 21:10:11 +0800 Subject: [PATCH 3/3] Dockerfile Removed comments --- src/services/cloud-storage/Dockerfile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/services/cloud-storage/Dockerfile b/src/services/cloud-storage/Dockerfile index 8d3593e..9e1668e 100644 --- a/src/services/cloud-storage/Dockerfile +++ b/src/services/cloud-storage/Dockerfile @@ -1,6 +1,5 @@ FROM node:8 -# Create app directory WORKDIR /usr/src/app COPY package.json ./ @@ -9,11 +8,10 @@ COPY yarn.lock ./ RUN yarn -# Bundle app source COPY . . #TODO : copy only source files. try multiple files. VOLUME /.clocal-gcp EXPOSE 8080 -CMD [ "npm", "start" ] \ No newline at end of file +CMD [ "npm", "start" ]