Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding wemake-python-styleguide support #1

Open
sobolevn opened this issue Feb 19, 2020 · 4 comments
Open

Consider adding wemake-python-styleguide support #1

sobolevn opened this issue Feb 19, 2020 · 4 comments

Comments

@sobolevn
Copy link
Collaborator

sobolevn commented Feb 19, 2020

I have looked through the code, it looks like wemake-python-styleguide support would be pretty easy to add.

Link: https://github.com/wemake-services/wemake-python-styleguide

@lensvol
Copy link
Owner

lensvol commented Feb 20, 2020

I've actually tried to run flake8 with wemake-python-styleguide, but it spat out 377 "violations". Most of them are actually intentional (use of print(), f-strings, uppercase letters in function names due to libcst convention, import libcst.matchers as m), some of them related to the use of black, and some of them really need fixing.

I will consider adding WPS in the future, but we need to compile a "whitelist" of violations that will actually be actioned upon.

In the meantime, if anyone submits a PR regarding this, it will be reviewed without prejudice. :)

@sobolevn
Copy link
Collaborator Author

I would love to help you here, but I am out of capacity 😞

@astynax
Copy link
Collaborator

astynax commented Feb 20, 2020

I'll send you PR soon :)

@lensvol
Copy link
Owner

lensvol commented Feb 20, 2020

@astynax That would be awesome! :)
@sobolevn No worries, we'll get there in time. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants