Type cast error when using FactoryConverter

[TheLastFlame]

Steps to Reproduce

Use FactoryConverter for a request with the specified response type.

Expected results:
Correct behavior similar to global converter usage

Actual results:
type 'List' is not a subtype of type 'Response<List<Map<String, dynamic>>>' in type cast

Code sample

@ChopperApi()
abstract class API extends ChopperService {
  static API create() {
    final client = ChopperClient(
      baseUrl: Uri.parse(url),
      converter: const JsonConverter(),
      errorConverter: const JsonConverter(),
    );
    return _$AuthorTodayAPI(client);
  }
  @FactoryConverter(response: convertResponse)
  @Get(path: path)
  Future<Response<List<Map<String, dynamic>>>> fetch();
}

FutureOr<Response<T>> convertResponse<T>(Response res) =>
    const JsonConverter().convertResponse(res);

Logs

type 'List<dynamic>' is not a subtype of type 'Response<List<Map<String, dynamic>>>' in type cast

No issues found!

Dart SDK version: 3.5.0 (stable) (Tue Jul 30 02:17:59 2024 -0700) on "windows_x64"

[techouse]

Hi, can you please provide an example / repo which reproduces this error?

[TheLastFlame]

Hi, can you please provide an example / repo which reproduces this error?

Is it possibly related to #173?

Hi. Unfortunately, I've already over-worked that code and I don't have any copies left.
I created a new project to demonstrate it, but I got a different behaviour.
Now I get this error even without FactoryConverter.

I'll try to investigate this further when I have more free time.

[techouse]

I was able to reproduce this with the following code snippet

import 'dart:async';
import 'package:chopper/chopper.dart';

part 'api.chopper.dart';

@ChopperApi()
abstract class ApiService extends ChopperService {
  static ApiService create([ChopperClient? client]) =>
      _$ApiService(client);

  @FactoryConverter(response: convertResponse)
  @GET(path: 'v2/breaches')
  Future<Response<List<Map<String, dynamic>>>> fetch();

  static FutureOr<Response<T>> convertResponse<T>(Response res) =>
      const JsonConverter().convertResponse(res);
}

Future<void> main() async {
  final chopper = ChopperClient(
    baseUrl: Uri.parse('https://haveibeenpwned.com/api/'),
    services: [
      ApiService.create(ChopperClient()),
    ],
    converter: JsonConverter(),
    errorConverter: const JsonConverter(),
  );

  final apiService = chopper.getService<ApiService>();

  final response = await apiService.fetch();
  print(response.body);

  chopper.dispose();
}

Which throws

Unhandled exception:
type 'CastList<dynamic, dynamic>' is not a subtype of type 'List<Map<String, dynamic>>?'

@TheLastFlame in order to fix it you have to provide the List's inner type

  static FutureOr<Response<T>> convertResponse<T>(Response res) =>
      const JsonConverter().convertResponse<
          T,
          Map<String, dynamic> // <-- you need to provide the inner type
      >(res);

Which would then summount to

@ChopperApi()
abstract class ApiService extends ChopperService {
  static ApiService create([ChopperClient? client]) => _$ApiService(client);

  @FactoryConverter(response: convertResponse)
  @GET(path: 'v2/breaches')
  Future<Response<List<Map<String, dynamic>>>> fetch();

  static FutureOr<Response<T>> convertResponse<T, Q extends Map<String, dynamic>>(Response res) =>
      const JsonConverter().convertResponse<T, Q>(res);
}