Skip to content

Commit e511cff

Browse files
authored
Merge pull request #144 from leetal/140_fix_invalid_version_number
Fixes #140
2 parents 14092d3 + bf86946 commit e511cff

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

.github/workflows/catalyst.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,28 +8,28 @@ on:
88

99
jobs:
1010
build_with_13_1_MAC_CATALYST:
11-
name: "Xcode version 13.1, Target macOS Catalyst on Apple Silicon [arm64] Target SDK 13.0"
11+
name: "Xcode version 13.1, Target macOS Catalyst on Intel CPUs [x86_64] Target SDK 13.1"
1212
runs-on: macos-11
1313
env:
1414
PLATFORM: MAC_CATALYST
15-
DEPLOYMENT_TARGET: "13.0"
15+
DEPLOYMENT_TARGET: "13.1"
1616
steps:
1717
- uses: actions/checkout@v2
1818
- uses: maxim-lobanov/setup-xcode@v1
1919
with:
2020
xcode-version: '13.1'
2121
- name: Build
2222
run: ./.github/build.sh
23-
build_with_13_1_MAC_CATALYST_ARM64:
24-
name: "Xcode version 13.2, Target macOS Catalyst on Intel CPUs [x86_64] Target SDK 13.0"
25-
runs-on: macos-11
23+
build_with_13_4_MAC_CATALYST_ARM64:
24+
name: "Xcode version 13.4, Target macOS Catalyst on Apple Silicon [arm64] Target SDK 13.1"
25+
runs-on: macos-12
2626
env:
2727
PLATFORM: MAC_CATALYST_ARM64
28-
DEPLOYMENT_TARGET: "13.0"
28+
DEPLOYMENT_TARGET: "13.1"
2929
steps:
3030
- uses: actions/checkout@v2
3131
- uses: maxim-lobanov/setup-xcode@v1
3232
with:
33-
xcode-version: '13.2'
33+
xcode-version: '13.4'
3434
- name: Build
3535
run: ./.github/build.sh

ios.toolchain.cmake

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,14 +245,14 @@ if(NOT DEFINED DEPLOYMENT_TARGET)
245245
set(DEPLOYMENT_TARGET "11.0")
246246
elseif(PLATFORM STREQUAL "MAC_CATALYST" OR PLATFORM STREQUAL "MAC_CATALYST_ARM64")
247247
# Unless specified, SDK version 13.0 is used by default as minimum target version (mac catalyst minimum requirement).
248-
set(DEPLOYMENT_TARGET "13.0")
248+
set(DEPLOYMENT_TARGET "13.1")
249249
else()
250250
# Unless specified, SDK version 11.0 is used by default as minimum target version (iOS, tvOS).
251251
set(DEPLOYMENT_TARGET "11.0")
252252
endif()
253253
message(STATUS "[DEFAULTS] Using the default min-version since DEPLOYMENT_TARGET not provided!")
254-
elseif(DEFINED DEPLOYMENT_TARGET AND PLATFORM MATCHES "^MAC_CATALYST" AND ${DEPLOYMENT_TARGET} VERSION_LESS "13.0")
255-
message(FATAL_ERROR "Mac Catalyst builds requires a minimum deployment target of 13.0!")
254+
elseif(DEFINED DEPLOYMENT_TARGET AND PLATFORM MATCHES "^MAC_CATALYST" AND ${DEPLOYMENT_TARGET} VERSION_LESS "13.1")
255+
message(FATAL_ERROR "Mac Catalyst builds requires a minimum deployment target of 13.1!")
256256
endif()
257257

258258
# Store the DEPLOYMENT_TARGET in the cache

0 commit comments

Comments
 (0)