-
Notifications
You must be signed in to change notification settings - Fork 930
Description
β This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Overview
Register the shared "All Picture Passwords" component under the facility plugin route /facility/#/classes/:id/passwords/ and add a "Print picture passwords" option to the existing options menu on ClassEditPage.
Complexity: Low
Target branch: develop
Context
This issue depends on the base shared "All Picture Passwords" component issue being complete. The shared component in packages/kolibri-common/components/ handles all data fetching, learner list display, format selection, and print triggering. This issue is only concerned with wiring up the facility plugin entry point and route.
learner_can_login_with_picture_password on the facility dataset is the source of truth for whether picture login is enabled. Before introducing any new store state, check how other facility settings fields are accessed in the facility plugin and follow that existing pattern.
The Change
1. Facility plugin route (kolibri/plugins/facility/frontend/routes.js)
Register /facility/#/classes/:id/passwords/ in the facility plugin router, pointing to the shared "All Picture Passwords" component from packages/kolibri-common/components/.
2. "Print picture passwords" entry point on ClassEditPage (kolibri/plugins/facility/frontend/views/ClassEditPage/index.vue)
Add a "Print picture passwords" option to the existing options KDropdownMenu on the facility plugin's ClassEditPage. This option must:
- Only render when
learner_can_login_with_picture_passwordisTruefor the facility - Navigate to
/facility/#/classes/:id/passwords/on selection - Use the "View Passwords" i18n string from
packages/kolibri-common/strings/picturePasswordStrings.js
Out of Scope
- Creating or updating the shared "All Picture Passwords" component itself
- The coach plugin entry points and route
- Any backend changes
Acceptance Criteria
General
-
/facility/#/classes/:classId/passwords/is registered in the facility plugin router and correctly renders the shared "All Picture Passwords" component - "Print Picture Passwords" option appears in the
ClassEditPageoptions menu only whenlearner_can_login_with_picture_passwordisTrue - Selecting the option navigates to
/facility/#/classes/:id/passwords/ - The option does not appear when
learner_can_login_with_picture_passwordisFalse
Testing
- "Print Picture Passwords" option does not render when
learner_can_login_with_picture_passwordisFalse - Selecting the option navigates to the correct facility plugin route
References
- Facility plugin
ClassEditPage - Facility plugin router
packages/kolibri-common/components/β shared "All Picture Passwords" componentpackages/kolibri-common/strings/picturePasswordStrings.js- Figma:
https://www.figma.com/design/ZNXancdqXCbCAPXmf6r1zi/Picture-login?node-id=147-460&t=cQs176c0M8wMJLMn-0
AI usage
π€ This issue was written with AI assistance, under supervision, review
and final edits by [@LianaHarris360] π€
