Add new Stamen Toner variants #671
Conversation
leaflet-providers.js
Outdated
| StamenTonerDark: { | ||
| options: { | ||
| attribution: | ||
| '© <a href="https://www.stadiamaps.com/" target="_blank">Stadia Maps</a> ' + |
There was a problem hiding this comment.
Tabs should be used instead of spaces, and it miss an indentation level here.
There was a problem hiding this comment.
Oh weird, my editor (WebStorm) claims that it was enforcing the configuration (looks like from eslint.config.mjs? not sure...). The format script doesn't actually reformat this, which is really confusing as a contributor 😅
There was a problem hiding this comment.
The format script doesn't actually reformat this, which is really confusing as a contributor
Ha, lint:fix didn't fix this ? Have to check this...
There was a problem hiding this comment.
Yeah, that's why I was surprised haha. That's what I ran. Ended up copying a sequence of tabs from other lines :D
There was a problem hiding this comment.
I've just checked with this diff :
diff --git a/leaflet-providers.js b/leaflet-providers.js
index a134d58..a3c3a5d 100644
--- a/leaflet-providers.js
+++ b/leaflet-providers.js
@@ -633,7 +633,7 @@
},
variants: {
exploreDay: 'explore.day',
- liteDay: 'lite.day',
+ liteDay: 'lite.day',
logisticsDay: 'logistics.day',
topoDay: 'topo.day',
logisticsNight: 'logistics.night',npm run lint
> [email protected] lint
> eslint leaflet-providers.js index.html preview/*.js preview/*.html tests/*
/home/bb/github/leaflet-providers/leaflet-providers.js
636:1 error Expected indentation of 4 tabs but found 16 spaces @stylistic/js/indent
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.
There was a problem hiding this comment.
Weird! I've definitely got a clean working copy (for all practical purposes?). I'm no JS expert, but I seem to remember npm install being at least somewhat deterministic when you had a lockfile committed (this project does). I also know nothing about the range of formatting tools available, but are they in any way dependent on node version or anything else? node --version returns v22.13.0.
Shell transcript below trying to replicate your npm run lint:
in leaflet-providers on master is 📦 v3.0.0 on ☁️ (us-central1)
at 00:28:40 ❯ npm run lint
> [email protected] lint
> eslint leaflet-providers.js index.html preview/*.js preview/*.html tests/*
[@stylistic/eslint-plugin-js] This package is deprecated in favor of the unified @stylistic/eslint-plugin, please consider migrating to the main package
in leaflet-providers on master is 📦 v3.0.0 on ☁️ (us-central1)
at 00:29:30 ❯ git status
On branch master
Your branch is up to date with 'origin/master'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
.idea/
nothing added to commit but untracked files present (use "git add" to track)
|
Thx @ianthetechie, could you format your commit as https://www.conventionalcommits.org/ Something like |
|
Sure thing. Done (I think) :D |
2 participants
Should be pretty straightforward. See https://stamen.com/what-we-map-in-the-shadows/.