This repository was archived by the owner on Dec 31, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Please remove TSLint from devDependencies #148
Copy link
Copy link
Open
Description
Title: Please remove TSLint from devDependencies
Repository: lddubeau/saxes (https://github.com/lddubeau/saxes)
Background:
We noticed that your project still lists tslint and tslint-* packages in devDependencies and contains some // tslint:disable-next-line comments in source files. TSLint has been deprecated in favor of ESLint + @typescript-eslint. Projects consuming your package may get TSLint mentions in lockfiles and audits even if they don't use TSLint themselves.
Request:
- Please consider removing
tslintandtslint-microsoft-contribfromdevDependencies. - Replace any TSLint-based checks with ESLint +
@typescript-eslintrules (or remove the linter command if not needed in CI). - Replace
tslintinline comments (e.g.,// tslint:disable-next-line:...) or explain why they must remain.
Suggested changes (example):
- Update
package.jsondevDependencies to droptslintand addeslint,@typescript-eslint/parser, and@typescript-eslint/eslint-plugin. - Add an
eslinttarget to CI orlintscript that runs ESLint for TS files.
Why this helps:
- Consumers of your package (including build tooling) will no longer see TSLint references in
node_modules. - Aligns the project with current TypeScript linting best practices.
I can open a draft PR with the minimal changes (add ESLint + typescript-eslint config and remove tslint from devDeps) if you'd like—please tell me whether you'd prefer a PR or an issue first.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels