Add -fdebug-prefix-map and follow clang's behavior for debuginfo file/dir names
#5039
+105
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanEngelen
force-pushed
the
fdebug-prefix-map
branch
from
d72d77d to
199ec97
Compare
…/dir names. This is required to have reproducible builds without remapping the source code directory to a fixed location (for example in Bazel, where the source code for every build action will end up in a sandbox directory with some hash in the path name). Try to keep the implementation as close as possible to what clang does.
JohanEngelen
force-pushed
the
fdebug-prefix-map
branch
from
199ec97 to
5698f68
Compare
Member
Author
|
I guess the test timeouts mean that indeed this now takes a lot of compile time to generate file info. Will implement a caching mechanism |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fdebug-prefix-map
This is required to have reproducible builds without remapping the source code directory to a fixed location (for example in Bazel, where the source code for every build action will end up in a sandbox directory with some hash in the path name).
Try to keep the implementation as close as possible to what clang does.
Originally implemented by Ilya, modified and expanded by Johan.