From c5a621be0771bb82a5c621e35b450368310aa649 Mon Sep 17 00:00:00 2001 From: Lachlan Priest Date: Tue, 13 Nov 2018 12:09:43 +0800 Subject: [PATCH] Translate textareas and add placeholders back --- addon/components/form-field.js | 9 --------- addon/components/form-fields/text-field.js | 3 ++- addon/components/form-fields/textarea-field.js | 3 ++- addon/mixins/translated-input.js | 14 ++++++++++++++ .../components/form-fields/hidden-field.hbs | 2 +- package.json | 2 +- 6 files changed, 20 insertions(+), 13 deletions(-) diff --git a/addon/components/form-field.js b/addon/components/form-field.js index a8162f8..bbb6e7c 100644 --- a/addon/components/form-field.js +++ b/addon/components/form-field.js @@ -130,15 +130,6 @@ const FormFieldComponent = Component.extend(TranslatedInput, { return get(this, 'modelName') || guidFor(get(this, 'object')); }, - getModelName() { - let formName = get(this, 'form'); - let modelName = get(this, 'object.modelName'); - let constructorName = get(this, 'object.constructor.modelName'); - let changesetConstructorName = get(this, 'object._content.constructor.modelName'); - - return formName || modelName || constructorName || changesetConstructorName; - }, - value: computed('rawValue', function() { let serializeValue = getWithDefault(this, 'serializeValue', (value) => value); return serializeValue(get(this, 'rawValue')); diff --git a/addon/components/form-fields/text-field.js b/addon/components/form-fields/text-field.js index f8371b2..5b8819f 100644 --- a/addon/components/form-fields/text-field.js +++ b/addon/components/form-fields/text-field.js @@ -1,12 +1,13 @@ import Ember from 'ember'; import layout from '../../templates/components/form-fields/text-field'; +import TranslatedInput from '../../mixins/translated-input'; const { Component, set } = Ember; -const TextFieldComponent = Component.extend({ +const TextFieldComponent = Component.extend(TranslatedInput, { tagName: '', layout, diff --git a/addon/components/form-fields/textarea-field.js b/addon/components/form-fields/textarea-field.js index c84d084..7dbdcb4 100644 --- a/addon/components/form-fields/textarea-field.js +++ b/addon/components/form-fields/textarea-field.js @@ -1,12 +1,13 @@ import Ember from 'ember'; import layout from '../../templates/components/form-fields/textarea-field'; +import TranslatedInput from '../../mixins/translated-input'; const { Component, set } = Ember; -const TextareaFieldComponent = Component.extend({ +const TextareaFieldComponent = Component.extend(TranslatedInput, { tagName: '', layout, diff --git a/addon/mixins/translated-input.js b/addon/mixins/translated-input.js index ede2e1a..71c2d20 100644 --- a/addon/mixins/translated-input.js +++ b/addon/mixins/translated-input.js @@ -12,6 +12,20 @@ const { export default Mixin.create({ intl: service(), + config: service('ember-form-for/config'), + + modelName: computed('form', 'object.{modelName,constructor.modelName,_content.constructor.modelName}', function() { + return this.getModelName(); + }), + + getModelName() { + let formName = get(this, 'form'); + let modelName = get(this, 'object.modelName'); + let constructorName = get(this, 'object.constructor.modelName'); + let changesetConstructorName = get(this, 'object._content.constructor.modelName'); + + return formName || modelName || constructorName || changesetConstructorName; + }, labelText: computed('propertyName', 'label', function() { let intl = get(this, 'intl'); diff --git a/addon/templates/components/form-fields/hidden-field.hbs b/addon/templates/components/form-fields/hidden-field.hbs index 0cdd15a..686e83a 100644 --- a/addon/templates/components/form-fields/hidden-field.hbs +++ b/addon/templates/components/form-fields/hidden-field.hbs @@ -31,7 +31,7 @@ minlength=minlength multiple=multiple pattern=pattern - placeholder=placeholderText + placeholder=placeholder readonly=readonly required=required size=size diff --git a/package.json b/package.json index 3f5ae90..2bd7d59 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ember-form-for-intl", - "version": "1.0.4", + "version": "1.0.6", "description": "Build \"Data Down Actions Up\" forms, with good default markup and built-in accessibility support", "keywords": [ "ember-addon"