Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer Channel Name Length #276

Open
fearthesmear opened this issue Jun 5, 2019 · 3 comments
Open

Longer Channel Name Length #276

fearthesmear opened this issue Jun 5, 2019 · 3 comments

Comments

@fearthesmear
Copy link

It appears that the maximum channel name length for the LCM Logger is 63 characters. LCM spy does not appear to have this restriction. This results in long channel names coming through on spy but not making it into the log file.

@judfs
Copy link
Contributor

judfs commented Apr 5, 2024

I have run into issues with this channel length restriction. I also cannot find anywhere that it is clearly documented that this restriction is in place.

It comes from https://github.com/lcm-proj/lcm/blob/master/lcm/lcm.h#L18

Reading [https://lcm-proj.github.io/lcm/content/udp-multicast-protocol.html](LCM UDP Multicast Protocol Description) and [https://lcm-proj.github.io/lcm/content/log-file-format.html](LCM Log File format), I don't see any reason increasing should be unviable.

This would be a 1.6.0 (or 2.0.0) change instead of a 1.5.1 change as this could cause incompatibilities 1.5.0.

@judfs
Copy link
Contributor

judfs commented May 21, 2024

@nosracd looks like you've made a 2.0 issue label. Any thoughts on roadmapping this?

@nosracd
Copy link
Contributor

nosracd commented Jun 16, 2024

@nosracd looks like you've made a 2.0 issue label. Any thoughts on roadmapping this?

That label is intended to help track breaking changes for when a 2.0 release looks likely but at this point there are no plans for a 2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants