Replace setUp/tearDown overrides with @Before/@after in inference tests (elastic#155785)

Replace @OverRide setUp()/tearDown() methods in x-pack/plugin/inference
tests with descriptively named @Before/@after methods, removing the
now-redundant super.setUp()/super.tearDown() calls.

Author: rjernst

x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/search/ccs/KnnMixedFieldTypeCrossClusterSearchIT.java

@@ -110,9 +110,7 @@ protected boolean reuseClusters() {
     }
 
     @Before
-    @Override
-    public void setUp() throws Exception {
-        super.setUp();
+    public void configureClustersIfNeeded() throws Exception {
         if (clustersConfigured == false) {
             configureClusters();
             clustersConfigured = true;

x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/search/ccs/KnnVectorQueryBuilderCrossClusterSearchIT.java

@@ -55,9 +55,7 @@ protected boolean reuseClusters() {
     }
 
     @Before
-    @Override
-    public void setUp() throws Exception {
-        super.setUp();
+    public void configureClustersIfNeeded() throws Exception {
         if (clustersConfigured == false) {
             configureClusters();
             clustersConfigured = true;

x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/search/ccs/MatchQueryBuilderCrossClusterSearchIT.java

@@ -48,9 +48,7 @@ protected boolean reuseClusters() {
     }
 
     @Before
-    @Override
-    public void setUp() throws Exception {
-        super.setUp();
+    public void configureInferenceEndpoints() throws Exception {
         configureClusters();
     }
 

x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/search/ccs/SemanticQueryBuilderCrossClusterSearchIT.java

@@ -50,9 +50,7 @@ protected boolean reuseClusters() {
     }
 
     @Before
-    @Override
-    public void setUp() throws Exception {
-        super.setUp();
+    public void configureClustersIfNeeded() throws Exception {
         if (clustersConfigured == false) {
             configureClusters();
             clustersConfigured = true;

x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/search/ccs/SparseVectorQueryBuilderCrossClusterSearchIT.java

@@ -37,9 +37,7 @@ protected boolean reuseClusters() {
     }
 
     @Before
-    @Override
-    public void setUp() throws Exception {
-        super.setUp();
+    public void configureClustersIfNeeded() throws Exception {
         if (clustersConfigured == false) {
             configureClusters();
             clustersConfigured = true;

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/action/BaseTransportInferenceActionTestCase.java

@@ -81,8 +81,7 @@ public BaseTransportInferenceActionTestCase(TaskType taskType) {
     }
 
     @Before
-    public void setUp() throws Exception {
-        super.setUp();
+    public void initMocks() throws Exception {
         ActionFilters actionFilters = mock();
         threadPool = mock();
         when(threadPool.getThreadContext()).thenReturn(new ThreadContext(Settings.EMPTY));

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/action/TransportDeleteCCMConfigurationActionTests.java

@@ -37,8 +37,7 @@ public class TransportDeleteCCMConfigurationActionTests extends ESTestCase {
     private TransportDeleteCCMConfigurationAction action;
 
     @Before
-    public void setUp() throws Exception {
-        super.setUp();
+    public void createAction() throws Exception {
         var ccmFeature = mock(CCMFeature.class);
         when(ccmFeature.isCcmSupportedEnvironment()).thenReturn(true);
 

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/action/TransportDeleteInferenceEndpointActionTests.java

@@ -58,8 +58,7 @@ public class TransportDeleteInferenceEndpointActionTests extends ESTestCase {
     private InferenceServiceRegistry mockInferenceServiceRegistry;
 
     @Before
-    public void setUp() throws Exception {
-        super.setUp();
+    public void createAction() throws Exception {
         threadPool = createThreadPool(inferenceUtilityExecutors());
         mockModelRegistry = mock(ModelRegistry.class);
         mockInferenceServiceRegistry = mock(InferenceServiceRegistry.class);
@@ -75,8 +74,7 @@ public void setUp() throws Exception {
     }
 
     @After
-    public void tearDown() throws Exception {
-        super.tearDown();
+    public void shutdownThreadPool() throws Exception {
         terminate(threadPool);
     }
 

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/action/TransportInferenceActionProxyTests.java

@@ -52,8 +52,7 @@ public class TransportInferenceActionProxyTests extends ESTestCase {
     private ModelRegistry modelRegistry;
 
     @Before
-    public void setUp() throws Exception {
-        super.setUp();
+    public void createAction() throws Exception {
         client = mock(Client.class);
         threadPool = new TestThreadPool("test");
         when(client.threadPool()).thenReturn(threadPool);
@@ -63,8 +62,7 @@ public void setUp() throws Exception {
     }
 
     @After
-    public void tearDown() throws Exception {
-        super.tearDown();
+    public void shutdownThreadPool() throws Exception {
         terminate(threadPool);
     }
 

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/action/TransportInternalDeleteEndpointsActionTests.java

@@ -40,8 +40,7 @@ public class TransportInternalDeleteEndpointsActionTests extends ESTestCase {
     private ModelRegistry mockModelRegistry;
 
     @Before
-    public void setUp() throws Exception {
-        super.setUp();
+    public void createAction() throws Exception {
         threadPool = createThreadPool(inferenceUtilityExecutors());
         mockModelRegistry = mock(ModelRegistry.class);
         action = new TransportInternalDeleteEndpointsAction(
@@ -54,8 +53,7 @@ public void setUp() throws Exception {
     }
 
     @After
-    public void tearDown() throws Exception {
-        super.tearDown();
+    public void shutdownThreadPool() throws Exception {
         terminate(threadPool);
     }