diff --git a/Buildings/Controls/OBC/CDL/Continuous/Sources/CalendarTime.mo b/Buildings/Controls/OBC/CDL/Continuous/Sources/CalendarTime.mo
index e49242612a3..adae91da1cb 100644
--- a/Buildings/Controls/OBC/CDL/Continuous/Sources/CalendarTime.mo
+++ b/Buildings/Controls/OBC/CDL/Continuous/Sources/CalendarTime.mo
@@ -38,7 +38,7 @@ model CalendarTime
protected
final constant Integer firstYear=2010
"First year that is supported, i.e. the first year in timeStampsNewYear[:]";
- final constant Integer lastYear=firstYear+11
+ final constant Integer lastYear=firstYear+21
"Last year that is supported (actual building automation system need to support a larger range)";
Buildings.Utilities.Time.CalendarTime calTim(
final zerTim=zerTim,
@@ -92,6 +92,11 @@ This is within the 2010-2020 range and is therefore allowed.
revisions="
-
+March 30, 2022, by Michael Wetter:
+Increased value of lastYear
as the underlying implementation allows
+for 21 years.
+
+-
November 12, 2020, by Michael Wetter:
Reformulated to remove dependency to Modelica.Units.SI
.
This is for
diff --git a/Buildings/Controls/OBC/CDL/Discrete/Sampler.mo b/Buildings/Controls/OBC/CDL/Discrete/Sampler.mo
index 02f176d5e5f..d53a67f2456 100644
--- a/Buildings/Controls/OBC/CDL/Discrete/Sampler.mo
+++ b/Buildings/Controls/OBC/CDL/Discrete/Sampler.mo
@@ -85,25 +85,6 @@ equation
preserveAspectRatio=true,
extent={{-100,-100},{100,100}}),
graphics={
- Ellipse(
- extent={{-25,-10},{-45,10}},
- lineColor={0,0,255},
- fillColor={255,255,255},
- fillPattern=FillPattern.Solid),
- Ellipse(
- extent={{45,-10},{25,10}},
- lineColor={0,0,255},
- fillColor={255,255,255},
- fillPattern=FillPattern.Solid),
- Line(
- points={{-100,0},{-45,0}},
- color={0,0,255}),
- Line(
- points={{45,0},{100,0}},
- color={0,0,255}),
- Line(
- points={{-35,0},{30,35}},
- color={0,0,255}),
Text(
extent={{226,60},{106,10}},
textColor={0,0,0},
@@ -120,6 +101,10 @@ via parameter samplePeriod
.
revisions="
-
+March 30, 2022, by Michael Wetter:
+Removed graphic from diagram view.
+
+-
November 12, 2020, by Michael Wetter:
Reformulated to remove dependency to Modelica.Units.SI
.
This is for
diff --git a/Buildings/Controls/OBC/CDL/Discrete/TriggeredMax.mo b/Buildings/Controls/OBC/CDL/Discrete/TriggeredMax.mo
index a751322630c..63094e0fa9d 100644
--- a/Buildings/Controls/OBC/CDL/Discrete/TriggeredMax.mo
+++ b/Buildings/Controls/OBC/CDL/Discrete/TriggeredMax.mo
@@ -68,28 +68,6 @@ equation
preserveAspectRatio=true,
extent={{-100,-100},{100,100}}),
graphics={
- Ellipse(
- extent={{-25,-10},{-45,10}},
- lineColor={0,0,255},
- fillColor={255,255,255},
- fillPattern=FillPattern.Solid),
- Ellipse(
- extent={{45,-10},{25,10}},
- lineColor={0,0,255},
- fillColor={255,255,255},
- fillPattern=FillPattern.Solid),
- Line(
- points={{-100,0},{-45,0}},
- color={0,0,255}),
- Line(
- points={{45,0},{100,0}},
- color={0,0,255}),
- Line(
- points={{-35,0},{28,-48}},
- color={0,0,255}),
- Line(
- points={{0,-100},{0,-26}},
- color={255,0,255}),
Text(
extent={{226,60},{106,10}},
textColor={0,0,0},
@@ -108,6 +86,10 @@ at the sampling point is provided as the output signal.
revisions="
-
+March 30, 2022, by Michael Wetter:
+Removed graphic from diagram view.
+
+-
March 2, 2020, by Michael Wetter:
Changed icon to display dynamically the output value.
diff --git a/Buildings/Controls/OBC/CDL/Discrete/TriggeredMovingMean.mo b/Buildings/Controls/OBC/CDL/Discrete/TriggeredMovingMean.mo
index 0708382384f..f8d378af6ae 100644
--- a/Buildings/Controls/OBC/CDL/Discrete/TriggeredMovingMean.mo
+++ b/Buildings/Controls/OBC/CDL/Discrete/TriggeredMovingMean.mo
@@ -27,7 +27,7 @@ protected
start=0,
fixed=true)
"Index of the vector ySample";
- Real ySample[n](
+ discrete Real ySample[n](
start=zeros(n),
each fixed=true)
"Vector of samples to be averaged";
@@ -174,6 +174,12 @@ and produces this value at its output y
.
revisions="
-
+March 30, 2022, by Michael Wetter:
+Added discrete
keyword to sampled variable.
+This is for
+issue 2942.
+
+-
October 19, 2020, by Michael Wetter:
Removed non-needed protected parameter t0
.
diff --git a/Buildings/Controls/OBC/CDL/Discrete/ZeroOrderHold.mo b/Buildings/Controls/OBC/CDL/Discrete/ZeroOrderHold.mo
index 2107d61a79e..ec418d4b4c8 100644
--- a/Buildings/Controls/OBC/CDL/Discrete/ZeroOrderHold.mo
+++ b/Buildings/Controls/OBC/CDL/Discrete/ZeroOrderHold.mo
@@ -50,8 +50,8 @@ equation
/* Define y=ySample with an infinitesimal delay to break potential
algebraic loops if both the continuous and the discrete part have
direct feedthrough
- */
- y=pre(ySample);
+ */
+ y=pre(ySample);
annotation (
defaultComponentName="zerOrdHol",
Icon(
diff --git a/Buildings/package.mo b/Buildings/package.mo
index 5075235d6b5..d82cf2753c0 100644
--- a/Buildings/package.mo
+++ b/Buildings/package.mo
@@ -362,7 +362,7 @@ have been improved in a
IBPSA, #1534.
-Buildings.Controls.OBC
+ |
Buildings.Controls.OBC.ASHRAE
|
Buildings.Controls.OBC.ASHRAE.G36_PR1.Generic.SetPoints.GroupStatus
@@ -371,7 +371,24 @@ have been improved in a
This is for # 2544.
|
-Buildings.Controls.OBC.Utilities.SunRiseSet
+ |
Buildings.Controls.OBC.CDL
+ |
+
+Buildings.Controls.OBC.CDL.Continuous.Sources.CalendarTime
+ |
+ Increased number of years that block will output the calendar time.
+ This is for
+ issue 2942.
+ |
+
+Buildings.Controls.OBC.CDL.Discrete.TriggeredMovingMean
+ |
+ Added missing discrete keyword to sampled variable.
+ This is for
+ issue 2942.
+ |
+
+Buildings.Controls.OBC.CDL.Utilities.SunRiseSet
|
Changed implementation to avoid NaN in OpenModelica.
This is for
|