From 265c7de66af502e1524c2c3f6424c5d2084a57fd Mon Sep 17 00:00:00 2001 From: Michael Wetter Date: Tue, 21 Nov 2017 14:06:24 -0800 Subject: [PATCH 1/4] Corrected wrong scaling of heat loss with number of panels For #1073 --- Buildings/Fluid/SolarCollectors/ASHRAE93.mo | 8 +- Buildings/Fluid/SolarCollectors/EN12975.mo | 10 +- .../Validation/EN12975NPanels.mo | 139 ++++++++++++++++++ .../SolarCollectors/Validation/FlatPlate.mo | 28 ++-- .../Validation/FlatPlateNPanels.mo | 92 ++++++++++++ .../SolarCollectors/Validation/package.order | 2 + ...SolarCollectors_Examples_Concentrating.txt | 8 +- ...ollectors_Examples_FlatPlateShaCoeTrue.txt | 8 +- ...Collectors_Examples_FlatPlateTotalArea.txt | 14 +- ...rCollectors_Examples_FlatPlateWithTank.txt | 8 +- ...Fluid_SolarCollectors_Examples_Tubular.txt | 8 +- ...arCollectors_Validation_EN12975NPanels.txt | 22 +++ ...Collectors_Validation_FlatPlateNPanels.txt | 22 +++ .../Validation/EN12975NPanels.mos | 5 + .../Validation/FlatPlateNPanels.mos | 5 + ...arCollectors.Validation.EN12975NPanels.mos | 11 ++ ...Collectors.Validation.FlatPlateNPanels.mos | 11 ++ 17 files changed, 361 insertions(+), 40 deletions(-) create mode 100644 Buildings/Fluid/SolarCollectors/Validation/EN12975NPanels.mo create mode 100644 Buildings/Fluid/SolarCollectors/Validation/FlatPlateNPanels.mo create mode 100644 Buildings/Resources/ReferenceResults/Dymola/Buildings_Fluid_SolarCollectors_Validation_EN12975NPanels.txt create mode 100644 Buildings/Resources/ReferenceResults/Dymola/Buildings_Fluid_SolarCollectors_Validation_FlatPlateNPanels.txt create mode 100644 Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Validation/EN12975NPanels.mos create mode 100644 Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Validation/FlatPlateNPanels.mos create mode 100644 Buildings/Resources/Scripts/OpenModelica/compareVars/Buildings.Fluid.SolarCollectors.Validation.EN12975NPanels.mos create mode 100644 Buildings/Resources/Scripts/OpenModelica/compareVars/Buildings.Fluid.SolarCollectors.Validation.FlatPlateNPanels.mos diff --git a/Buildings/Fluid/SolarCollectors/ASHRAE93.mo b/Buildings/Fluid/SolarCollectors/ASHRAE93.mo index 3ddad27c314..3767686244c 100644 --- a/Buildings/Fluid/SolarCollectors/ASHRAE93.mo +++ b/Buildings/Fluid/SolarCollectors/ASHRAE93.mo @@ -26,7 +26,7 @@ model ASHRAE93 "Model of a flat plate solar thermal collector" final G_nominal=per.G_nominal, dT_nominal=per.dT_nominal, final A_c=TotalArea_internal, - m_flow_nominal=per.mperA_flow_nominal*per.A, + m_flow_nominal=per.mperA_flow_nominal*per.A*nPanels_internal, final cp_default=cp_default) "Calculates the heat lost to the surroundings using the ASHRAE93 standard calculations" annotation (Placement(transformation(extent={{-20,6},{0,26}}))); @@ -176,6 +176,12 @@ equation ", revisions="