Skip to content

sqlx has same dependencies with and without macros feature #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vkgnosis opened this issue Jan 8, 2021 · 1 comment
Closed

sqlx has same dependencies with and without macros feature #968

vkgnosis opened this issue Jan 8, 2021 · 1 comment

Comments

@vkgnosis
Copy link

vkgnosis commented Jan 8, 2021

  • Create an empty project: cargo init --bin foo
  • Depend on sqlx with minimal features: `sqlx = { version = "0.4", default-features = false, features = ["runtime-async-std-native-tls"] }
  • cargo tree > dependencies0
  • Add the macros feature sqlx = { version = "0.4", default-features = false, features = ["runtime-async-std-native-tls", "macros"] }
  • cargo tree > dependencies1
  • diff dependencies0 dependencies1 shows the files are the same

It is surprising to me that the dependencies are the same. I expected less dependencies without the feature as these kind of features are usually used to reduce compilation time.

@abonander
Copy link
Collaborator

Duplicate of #955

@abonander abonander marked this as a duplicate of #955 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants