wip: test option 1 - update existing tests with data provider

Author: michaeldyrynda

tests/Cache/CacheApcStoreTest.php

@@ -28,20 +28,22 @@ public function testGetReturnsNullWhenNotFound()
         $this->assertNull($store->get('bar'));
     }
 
-    public function testAPCValueIsReturned()
+    #[DataProvider('resolveKeyNameDataProvider')]
+    public function testAPCValueIsReturned(mixed $key, string $expected)
     {
         $apc = $this->getMockBuilder(ApcWrapper::class)->onlyMethods(['get'])->getMock();
-        $apc->expects($this->once())->method('get')->willReturn('bar');
+        $apc->expects($this->once())->method('get')->with($this->equalTo($expected))->willReturn('bar');
         $store = new ApcStore($apc);
-        $this->assertSame('bar', $store->get('foo'));
+        $this->assertSame('bar', $store->get($key));
     }
 
-    public function testAPCFalseValueIsReturned()
+    #[DataProvider('resolveKeyNameDataProvider')]
+    public function testAPCFalseValueIsReturned(mixed $key, string $expected)
     {
         $apc = $this->getMockBuilder(ApcWrapper::class)->onlyMethods(['get'])->getMock();
-        $apc->expects($this->once())->method('get')->willReturn(false);
+        $apc->expects($this->once())->method('get')->with($this->equalTo($expected))->willReturn(false);
         $store = new ApcStore($apc);
-        $this->assertFalse($store->get('foo'));
+        $this->assertFalse($store->get($key));
     }
 
     public function testGetMultipleReturnsNullWhenNotFoundAndValueWhenFound()
@@ -60,14 +62,15 @@ public function testGetMultipleReturnsNullWhenNotFoundAndValueWhenFound()
         ], $store->many(['foo', 'bar', 'baz']));
     }
 
-    public function testSetMethodProperlyCallsAPC()
+    #[DataProvider('resolveKeyNameDataProvider')]
+    public function testSetMethodProperlyCallsAPC(mixed $key, string $expected)
     {
         $apc = $this->getMockBuilder(ApcWrapper::class)->onlyMethods(['put'])->getMock();
         $apc->expects($this->once())
-            ->method('put')->with($this->equalTo('foo'), $this->equalTo('bar'), $this->equalTo(60))
+            ->method('put')->with($this->equalTo($expected), $this->equalTo('bar'), $this->equalTo(60))
             ->willReturn(true);
         $store = new ApcStore($apc);
-        $result = $store->put('foo', 'bar', 60);
+        $result = $store->put($key, 'bar', 60);
         $this->assertTrue($result);
     }
 
@@ -99,39 +102,43 @@ public function testSetMultipleMethodProperlyCallsAPC()
         $this->assertTrue($result);
     }
 
-    public function testIncrementMethodProperlyCallsAPC()
+    #[DataProvider('resolveKeyNameDataProvider')]
+    public function testIncrementMethodProperlyCallsAPC(mixed $key, string $expected)
     {
         $apc = $this->getMockBuilder(ApcWrapper::class)->onlyMethods(['increment'])->getMock();
-        $apc->expects($this->once())->method('increment')->with($this->equalTo('foo'), $this->equalTo(5));
+        $apc->expects($this->once())->method('increment')->with($this->equalTo($expected), $this->equalTo(5));
         $store = new ApcStore($apc);
-        $store->increment('foo', 5);
+        $store->increment($key, 5);
     }
 
-    public function testDecrementMethodProperlyCallsAPC()
+    #[DataProvider('resolveKeyNameDataProvider')]
+    public function testDecrementMethodProperlyCallsAPC(mixed $key, string $expected)
     {
         $apc = $this->getMockBuilder(ApcWrapper::class)->onlyMethods(['decrement'])->getMock();
-        $apc->expects($this->once())->method('decrement')->with($this->equalTo('foo'), $this->equalTo(5));
+        $apc->expects($this->once())->method('decrement')->with($this->equalTo($expected), $this->equalTo(5));
         $store = new ApcStore($apc);
-        $store->decrement('foo', 5);
+        $store->decrement($key, 5);
     }
 
-    public function testStoreItemForeverProperlyCallsAPC()
+    #[DataProvider('resolveKeyNameDataProvider')]
+    public function testStoreItemForeverProperlyCallsAPC(mixed $key, string $expected)
     {
         $apc = $this->getMockBuilder(ApcWrapper::class)->onlyMethods(['put'])->getMock();
         $apc->expects($this->once())
-            ->method('put')->with($this->equalTo('foo'), $this->equalTo('bar'), $this->equalTo(0))
+            ->method('put')->with($this->equalTo($expected), $this->equalTo('bar'), $this->equalTo(0))
             ->willReturn(true);
         $store = new ApcStore($apc);
-        $result = $store->forever('foo', 'bar');
+        $result = $store->forever($key, 'bar');
         $this->assertTrue($result);
     }
 
-    public function testForgetMethodProperlyCallsAPC()
+    #[DataProvider('resolveKeyNameDataProvider')]
+    public function testForgetMethodProperlyCallsAPC(mixed $key, string $expected)
     {
         $apc = $this->getMockBuilder(ApcWrapper::class)->onlyMethods(['delete'])->getMock();
-        $apc->expects($this->once())->method('delete')->with($this->equalTo('foo'))->willReturn(true);
+        $apc->expects($this->once())->method('delete')->with($this->equalTo($expected))->willReturn(true);
         $store = new ApcStore($apc);
-        $result = $store->forget('foo');
+        $result = $store->forget($key);
         $this->assertTrue($result);
     }