refactor to use first-class callables

Signed-off-by: Pushpak Chhajed <[email protected]>

Author: pushpak1300

rector.php

@@ -5,7 +5,6 @@
 use Rector\CodingStyle\Rector\Encapsed\EncapsedStringsToSprintfRector;
 use Rector\Config\RectorConfig;
 use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
-use Rector\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector;
 use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
 
 return RectorConfig::configure()
@@ -17,13 +16,11 @@
         ReadOnlyPropertyRector::class,
         EncapsedStringsToSprintfRector::class,
         DisallowedEmptyRuleFixerRector::class,
-        BooleanInBooleanNotRuleFixerRector::class,
     ])
     ->withPreparedSets(
         deadCode: true,
         codeQuality: true,
         codingStyle: true,
         typeDeclarations: true,
         earlyReturn: true,
-        strictBooleans: true,
     )->withPhpSets(php81: true);

src/BoostServiceProvider.php

@@ -73,7 +73,7 @@ public function boot(Router $router): void
 
         if (config('boost.browser_logs_watcher', true)) {
             $this->registerBrowserLogger();
-            $this->callAfterResolving('blade.compiler', fn (BladeCompiler $bladeCompiler) => $this->registerBladeDirectives($bladeCompiler));
+            $this->callAfterResolving('blade.compiler', $this->registerBladeDirectives(...));
             $this->hookIntoResponses($router);
         }
     }

src/Install/CodeEnvironmentsDetector.php

@@ -55,6 +55,6 @@ public function discoverProjectInstalledCodeEnvironments(string $basePath): arra
     public function getCodeEnvironments(): Collection
     {
         return collect($this->boostManager->getCodeEnvironments())
-            ->map(fn (string $className) => $this->container->make($className));
+            ->map($this->container->make(...)); // @phpstan-ignore argument.type
     }
 }

src/Install/Detection/DetectionStrategyFactory.php

@@ -22,7 +22,7 @@ public function make(string|array $type, array $config = []): DetectionStrategy
     {
         if (is_array($type)) {
             return new CompositeDetectionStrategy(
-                array_map(fn ($singleType): \Laravel\Boost\Install\Contracts\DetectionStrategy => $this->make($singleType, $config), $type)
+                array_map(fn (string|array $singleType): \Laravel\Boost\Install\Contracts\DetectionStrategy => $this->make($singleType, $config), $type)
             );
         }
 

src/Install/GuidelineComposer.php

@@ -311,7 +311,7 @@ protected function guideline(string $path, bool $thirdParty = false): array
 
     protected function processBoostSnippets(string $content): string
     {
-        return preg_replace_callback('/(?<!@)@boostsnippet\(\s*(?P<nameQuote>[\'"])(?P<name>[^\1]*?)\1(?:\s*,\s*(?P<langQuote>[\'"])(?P<lang>[^\3]*?)\3)?\s*\)(?P<content>.*?)@endboostsnippet/s', function ($matches): string {
+        return preg_replace_callback('/(?<!@)@boostsnippet\(\s*(?P<nameQuote>[\'"])(?P<name>[^\1]*?)\1(?:\s*,\s*(?P<langQuote>[\'"])(?P<lang>[^\3]*?)\3)?\s*\)(?P<content>.*?)@endboostsnippet/s', function (array $matches): string {
             $name = $matches['name'];
             $lang = empty($matches['lang']) ? 'html' : $matches['lang'];
             $snippetContent = $matches['content'];

src/Mcp/Tools/DatabaseSchema/MySQLSchemaDriver.php

@@ -43,7 +43,7 @@ public function getFunctions(): array
     public function getTriggers(?string $table = null): array
     {
         try {
-            if ($table !== null && $table !== '' && $table !== '0') {
+            if (! in_array($table, [null, '', '0'], true)) {
                 return DB::connection($this->connection)->select('SHOW TRIGGERS WHERE `Table` = ?', [$table]);
             }
 

src/Mcp/Tools/DatabaseSchema/PostgreSQLSchemaDriver.php

@@ -60,7 +60,7 @@ public function getTriggers(?string $table = null): array
                 FROM information_schema.triggers
                 WHERE trigger_schema = current_schema()
             ';
-            if ($table !== null && $table !== '' && $table !== '0') {
+            if (! in_array($table, [null, '', '0'], true)) {
                 $sql .= ' AND event_object_table = ?';
 
                 return DB::connection($this->connection)->select($sql, [$table]);

src/Mcp/Tools/DatabaseSchema/SQLiteSchemaDriver.php

@@ -36,7 +36,7 @@ public function getTriggers(?string $table = null): array
     {
         try {
             $sql = "SELECT name, sql FROM sqlite_master WHERE type = 'trigger'";
-            if ($table !== null && $table !== '' && $table !== '0') {
+            if (! in_array($table, [null, '', '0'], true)) {
                 $sql .= ' AND tbl_name = ?';
 
                 return DB::connection($this->connection)->select($sql, [$table]);

src/Support/Composer.php

@@ -13,7 +13,7 @@ public static function packagesDirectories(): array
                 base_path('vendor'),
                 str_replace('/', DIRECTORY_SEPARATOR, $package),
             ])])
-            ->filter(fn (string $path): bool => is_dir($path))
+            ->filter(is_dir(...))
             ->toArray();
     }
 
@@ -45,7 +45,7 @@ public static function packagesDirectoriesWithBoostGuidelines(): array
                 'resources',
                 'boost',
                 'guidelines',
-            ]))->filter(fn (string $path): bool => is_dir($path))
+            ]))->filter(is_dir(...))
             ->toArray();
     }
 }

tests/Feature/Mcp/ToolExecutorTest.php

@@ -11,7 +11,7 @@
         ->shouldAllowMockingProtectedMethods();
     $executor->shouldReceive('buildCommand')
         ->once()
-        ->andReturnUsing(fn ($toolClass, $arguments): array => buildSubprocessCommand($toolClass, $arguments));
+        ->andReturnUsing(buildSubprocessCommand(...));
 
     $response = $executor->execute(GetConfig::class, ['key' => 'app.name']);
 
@@ -42,7 +42,7 @@
     $executor = Mockery::mock(ToolExecutor::class)->makePartial()
         ->shouldAllowMockingProtectedMethods();
     $executor->shouldReceive('buildCommand')
-        ->andReturnUsing(fn ($toolClass, $arguments): array => buildSubprocessCommand($toolClass, $arguments));
+        ->andReturnUsing(buildSubprocessCommand(...));
 
     $response1 = $executor->execute(Tinker::class, ['code' => 'return getmypid();']);
     $response2 = $executor->execute(Tinker::class, ['code' => 'return getmypid();']);
@@ -62,7 +62,7 @@
     $executor = Mockery::mock(ToolExecutor::class)->makePartial()
         ->shouldAllowMockingProtectedMethods();
     $executor->shouldReceive('buildCommand')
-        ->andReturnUsing(fn ($toolClass, $arguments): array => buildSubprocessCommand($toolClass, $arguments));
+        ->andReturnUsing(buildSubprocessCommand(...));
 
     // Path to the GetConfig tool that we'll temporarily modify
     // TODO: Improve for parallelisation
@@ -136,7 +136,7 @@ function buildSubprocessCommand(string $toolClass, array $arguments): array
         ->shouldAllowMockingProtectedMethods();
 
     $executor->shouldReceive('buildCommand')
-        ->andReturnUsing(fn ($toolClass, $arguments): array => buildSubprocessCommand($toolClass, $arguments));
+        ->andReturnUsing(buildSubprocessCommand(...));
 
     // Test with custom timeout - should succeed with fast code
     $response = $executor->execute(Tinker::class, [