-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version number as part of build process #3
Comments
Somebody backport and maintain Originally posted by @Ocramius at zendframework/ZendSkeletonApplication#356 (comment) |
Banning @Ocramius for blatant advertisment. Originally posted by @GeeH at zendframework/ZendSkeletonApplication#356 (comment) |
On a serious note, would you have a problem with this repository having a dependency on Originally posted by @GeeH at zendframework/ZendSkeletonApplication#356 (comment) |
Originally posted by @Ocramius at zendframework/ZendSkeletonApplication#356 (comment) |
It's easier if we just up the requirements of this skeleton application to 7.0.x. Originally posted by @GeeH at zendframework/ZendSkeletonApplication#356 (comment) |
That might be true but i think de dependcy on PHP-7 for the default app that 90% of people will start with is just to soon. Originally posted by @stijnhau at zendframework/ZendSkeletonApplication#356 (comment) |
@Ocramius I forked your Originally posted by @samsonasik at zendframework/ZendSkeletonApplication#356 (comment) |
there is a samsonasik/package-versions now! a backport of ocramius/package-versions that support php 5.6 ;) Originally posted by @samsonasik at zendframework/ZendSkeletonApplication#356 (comment) |
I've created PR #371 for it to use samsonasik/package-versions as backport of ocramius/package-versions that support php 5.6 ;) Originally posted by @samsonasik at zendframework/ZendSkeletonApplication#356 (comment) |
And... despite having this and related issues open today... I forgot to bump the version when I released 3.0.3 a short bit ago, belying the need for this to be in place. I'm still unsure how to proceed. The version constant approach does have use cases in terms of us helping understand where to start with a user, but typically the output of In many ways, I think I'd rather just drop the version constant altogether. Thoughts? Originally posted by @weierophinney at zendframework/ZendSkeletonApplication#356 (comment) |
As I remember correctly the idea to have the constant was for easier investigating issues with the skeleton, to help resolve reported issues. It is going to help only with issues only in the skeleton, not in dependencies, as I've mentioned already over a year ago zendframework/ZendSkeletonApplication#371 (comment) and suggested there dropping the version constant. Removing the version constant from the skeleton - YES from me 👍 Originally posted by @michalbundyra at zendframework/ZendSkeletonApplication#356 (comment) |
We need to to this as part of release but I have no idea how.
Suggestions.
Originally posted by @GeeH at zendframework/ZendSkeletonApplication#356
The text was updated successfully, but these errors were encountered: