Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Remove laminas-db from require-dev #107

Open
arhimede opened this issue Feb 7, 2025 · 8 comments
Open

[RFC]: Remove laminas-db from require-dev #107

arhimede opened this issue Feb 7, 2025 · 8 comments
Labels
Milestone

Comments

@arhimede
Copy link
Member

arhimede commented Feb 7, 2025

RFC

Q A
Proposed Version(s) 2.25.0
BC Break? Yes

Goal

Remove laminas-db from require-dev and remove the SaveHandler DbTableGateway class

Background

Currently, in composer , at the require-dev section, it's called the laminas-db package.
Also, composer allow PHP 8.4 but laminas-db does not allow it (yet).
laminas-db is in security mode, so we should not use it in new releases

Considerations

We should decide if the save handler TableGateway is a MUST
If we should remove it or replace it with something else....

Proposal(s)

Remove laminas-db from require-dev and remove the SaveHandler DbTableGateway class

@arhimede arhimede added the RFC label Feb 7, 2025
@gsteel
Copy link
Member

gsteel commented Feb 7, 2025

Kill it with 🔥 as @Ocramius would say

We dropped the record not|exists validators in v3 of validator.

This stuff belongs in its own package and users can always copy/paste the implementation from older releases if neccesary.

@froschdesign
Copy link
Member

We dropped the record not|exists validators in v3 of validator.

Even if I think this is right, it always raises questions.

This stuff belongs in its own package…

This path should be taken.

@Ocramius
Copy link
Member

Ocramius commented Feb 7, 2025

I'd say "drop it", and we then move it to a separate package, as @froschdesign correctly mentions.

The dependency graph needs to be slimmed down here

@arhimede
Copy link
Member Author

arhimede commented Mar 5, 2025

@laminas/technical-steering-committee
We are about to do a PR to remove laminas-db from the next major release.
We are thinking to remove the MongoDB too .
And recommend eventually to have a separate package which extend this one , if somebody want to use the sessions with mongodb handler, or mysql handler, or redis or etc.
Opinions ?

@froschdesign
Copy link
Member

@arhimede
Many more considerations are required, like:

  • replace laminas-cache with a PSR interface
  • update the entire code base
  • define laminas-validator as a hard requirement

Maybe a project will help here or an issue report with sub-issues.

@arhimede
Copy link
Member Author

arhimede commented Mar 5, 2025

@arhimede Many more considerations are required, like:

* replace laminas-cache with a PSR interface

* update the entire code base

* define laminas-validator as a hard requirement

* …

Maybe a project will help here or an issue report with sub-issues.

Ok, I created few sub-issues, the last one worries me 😄
If there are other ideas , please add comments.

@froschdesign
Copy link
Member

@arhimede arhimede added this to the 3.0.0 milestone Mar 5, 2025
@arhimede
Copy link
Member Author

arhimede commented Mar 5, 2025

@froschdesign i moved all those subissues under the main issue , #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants