Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This repository needs a rewrite #2

Open
weierophinney opened this issue Dec 31, 2019 · 4 comments
Open

This repository needs a rewrite #2

weierophinney opened this issue Dec 31, 2019 · 4 comments

Comments

@weierophinney
Copy link
Contributor

This repo was written in the context of Apigility. It is very useful in Apigility but the name of this repository and what it does best is to populate a QueryBuilder based on an array. For instance this is used in api-skeletons/zf-doctrine-graphql where Apigility shouldn't be a requirement.

Specific problems

  • Hydrator\Strategy\CollectionLink is specific to Apigility. This strategy is duplicated in api-skeleletons/zf-doctrine-hydrator (which also has strategies in the same tool type as this strategy)
  • Query Providers are specific to Apigility. I think these classes would do well in their own repository.

And with these out of the way this repo can do the job of array > Query Builder cleanly.

I'm willing to do this for a cleaner repo. What do you say?


Originally posted by @TomHAnderson at zfcampus/zf-doctrine-querybuilder#51

@TomHAnderson
Copy link
Contributor

100% yes. You have clearly articulated the problems I also see in this repository.

I think the new repo should be among api-tools since it's a sister to this repository and also belongs among the apigility legacy.

@TomHAnderson
Copy link
Contributor

TomHAnderson commented Feb 4, 2020

zf-doctrine-hydrator would be a good addition to api-tools, I feel, but I don't know how much more Doctrine you want to mix in the project. api-tools-doctrine-minutia? I suppose I'm saying I'd like to know the strategy for Doctrine in api-tools.

@TomHAnderson
Copy link
Contributor

Here is my answer to the original post:

Separate filtering libraries for ORM and ODM
#6
#7

A new repository to provide better query provider tools including the default query provider.
https://github.com/TomHAnderson/api-tools-doctrine-query-provider

@TomHAnderson
Copy link
Contributor

An issue with creating a query-provider repo is we're not including query-create-filters. These can be rolled into query-provider: https://github.com/TomHAnderson/api-tools-doctrine-query-provider/blob/master/config/module.config.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants