Make MemorySegmentManager's memory field private (#2164)

* Make memory private

* Add public getters for memory

* Update changelog

* Replace std Cow with nostd Cow

* Increase code coverage

Author: JulianGCalderon

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 #### Upcoming Changes
 
+* fix: make `MemorySegmentManager`'s `memory` field private [#2164](https://github.com/lambdaclass/cairo-vm/pull/2164)
+
 * feat: Use BTreeMap in PIE additional data [#2162](https://github.com/lambdaclass/cairo-vm/pull/2162)
 
 * feat: Remove prover input info struct and add getters instead [#2149](https://github.com/lambdaclass/cairo-vm/pull/2149)

vm/src/vm/vm_memory/memory_segments.rs

@@ -1,3 +1,4 @@
+use crate::stdlib::borrow::Cow;
 use crate::stdlib::collections::HashSet;
 use core::cmp::max;
 use core::fmt;
@@ -23,7 +24,7 @@ use super::memory::MemoryCell;
 pub struct MemorySegmentManager {
     pub segment_sizes: HashMap<usize, usize>,
     pub segment_used_sizes: Option<Vec<usize>>,
-    pub memory: Memory,
+    pub(crate) memory: Memory,
     // A map from segment index to a list of pairs (offset, page_id) that constitute the
     // public memory. Note that the offset is absolute (not based on the page_id).
     pub public_memory_offsets: HashMap<usize, Vec<(usize, usize)>>,
@@ -328,6 +329,16 @@ impl MemorySegmentManager {
         }
         Ok(())
     }
+
+    pub fn get_integer(&self, key: Relocatable) -> Result<Felt252, MemoryError> {
+        self.memory.get_integer(key).map(Cow::into_owned)
+    }
+    pub fn get_relocatable(&self, key: Relocatable) -> Result<Relocatable, MemoryError> {
+        self.memory.get_relocatable(key)
+    }
+    pub fn get_maybe_relocatable(&self, key: Relocatable) -> Result<MaybeRelocatable, MemoryError> {
+        self.memory.get_maybe_relocatable(key)
+    }
 }
 
 impl Default for MemorySegmentManager {
@@ -1117,4 +1128,47 @@ mod tests {
             ])
         );
     }
+
+    #[test]
+    fn test_get_integer() {
+        let mut memory_segment_manager = MemorySegmentManager::new();
+        memory_segment_manager.memory = memory![((0, 0), 10)];
+        assert_eq!(
+            memory_segment_manager
+                .get_integer(Relocatable::from((0, 0)))
+                .unwrap()
+                .as_ref(),
+            &Felt252::from(10)
+        );
+    }
+
+    #[test]
+    fn test_get_relocatable() {
+        let mut memory_segment_manager = MemorySegmentManager::new();
+        memory_segment_manager.memory = memory![((0, 0), (0, 1))];
+        assert_eq!(
+            memory_segment_manager
+                .get_relocatable(Relocatable::from((0, 0)))
+                .unwrap(),
+            relocatable!(0, 1)
+        );
+    }
+
+    #[test]
+    fn test_get_maybe_relocatable() {
+        let mut memory_segment_manager = MemorySegmentManager::new();
+        memory_segment_manager.memory = memory![((0, 0), (0, 1)), ((0, 1), 10)];
+        assert_eq!(
+            memory_segment_manager
+                .get_maybe_relocatable(relocatable!(0, 0))
+                .unwrap(),
+            mayberelocatable!(0, 1)
+        );
+        assert_eq!(
+            memory_segment_manager
+                .get_maybe_relocatable(relocatable!(0, 1))
+                .unwrap(),
+            mayberelocatable!(10)
+        );
+    }
 }