Merge branch 'main' into remove-unused-error-variants

Author: FrancoGiachetta

.github/workflows/bench.yml

@@ -1,8 +1,8 @@
-name: benchmark 
+name: benchmark
 
 on:
   push:
-    branches: [ main ]
+    branches: [ main, starkware-development ]
 
 permissions:
   # deployments permission to deploy GitHub pages website
@@ -12,13 +12,13 @@ permissions:
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
     - name: Install Rust
-      uses: dtolnay/rust-toolchain@1.74.1
+      uses: dtolnay/rust-toolchain@1.85.0
       with:
           components: rustfmt, clippy
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Python3 Build
       uses: actions/setup-python@v4
       with:

.github/workflows/cairo_1_programs.yml

@@ -2,21 +2,21 @@ name: Cairo 1 programs execution
 
 on:
   push:
-    branches: [ main ]
+    branches: [ main, starkware-development ]
   pull_request:
     branches: [ '**' ]
 
 jobs:
   run:
     name: Execute programs
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@1.74.1
+        uses: dtolnay/rust-toolchain@1.85.0
       - name: Set up Cargo cache
         uses: Swatinem/rust-cache@v2
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: install corelib
         run:  cd cairo1-run/ && make deps
       - name: Run tests

.github/workflows/changelog.yml

@@ -13,4 +13,4 @@ jobs:
     steps:
     - uses: dangoslen/changelog-enforcer@v3
       with:
-        skipLabels: pipelines,tests,documentation
+        skipLabels: nochangelog,pipelines,tests,documentation

.github/workflows/fresh_run.yml

@@ -17,8 +17,8 @@ jobs:
           - os: ubuntu-22.04
             deps_suffix: ''
             os_name: ubuntu-22.04
-          - os: [self-hosted, macOS]
-            deps_suffix: '-macos' 
+          - os: macos-latest
+            deps_suffix: '-macos'
             os_name: macos
     runs-on: ${{ matrix.os_name }}
     name: "Make deps, build & test on fresh ${{ matrix.os_name }} system"
@@ -33,12 +33,12 @@ jobs:
         sudo rm -rf /opt/ghc
         sudo rm -rf "/usr/local/share/boost"
         sudo rm -rf "$AGENT_TOOLSDIRECTORY"
-     
+
     - name: Checkout
-      uses: actions/checkout@v3
-    
+      uses: actions/checkout@v4
+
     - name: Install Rust
-      uses: dtolnay/rust-toolchain@1.74.1
+      uses: dtolnay/rust-toolchain@1.85.0
 
     - name: Install Pyenv
       uses: "gabrielfalcao/pyenv-action@v13"
@@ -68,7 +68,7 @@ jobs:
             FAILED_TARGET=deps${{ matrix.deps_suffix }}
         elif [ ${{ steps.build.outcome }} = failure ]; then
             FAILED_TARGET=build
-        else 
+        else
             FAILED_TARGET=test
         fi
         echo "FAILED_TARGET=$FAILED_TARGET" >> $GITHUB_ENV

.github/workflows/fuzzer.yml

@@ -9,7 +9,7 @@ jobs:
     steps:
 
     - name: Checkout
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         ref: ${{ github.head_ref }}
 
@@ -22,7 +22,7 @@ jobs:
         path: fuzzer/hfuzz_workspace/fuzz_json/input
         key: ${{ runner.os }}-inputs
 
-    
+
     - name: Install dependencies
       run: |
         sudo apt-get update
@@ -38,12 +38,12 @@ jobs:
       run: cargo install honggfuzz
 
     # If has cached inputs starts with them or else starts from 0
-    - name: Initializing fuzzer with previous inputs 
+    - name: Initializing fuzzer with previous inputs
       run: |
         cd fuzzer
         HFUZZ_RUN_ARGS="--dict=json.dict --run_time 10800 --timeout 60" cargo hfuzz run fuzz_json
 
-    # run the fuzzer with minimize to reduce inputs 
+    # run the fuzzer with minimize to reduce inputs
     - name: Initializing fuzzer with minimize
       run: |
         cd fuzzer
@@ -55,20 +55,20 @@ jobs:
         file_pattern: '*/hfuzz_workspace/fuzzer/fuzz_json/HONGGFUZZ*  */hfuzz_workspace/fuzzer/fuzz_json/*.fuzz'
 
     # Checkout current and last commit for the diff
-    - name: Checkout commits  
-      uses: actions/checkout@v3
+    - name: Checkout commits
+      uses: actions/checkout@v4
       with:
         fetch-depth: 2
 
     # Check if any new crashes were added
     - name: Check diff
       id: check_file_changed
-      run:  echo "report=$(git diff --name-only HEAD^ HEAD -- fuzzer/hfuzz_workspace/fuzz_json/*.fuzz)" >> $GITHUB_OUTPUT 
+      run:  echo "report=$(git diff --name-only HEAD^ HEAD -- fuzzer/hfuzz_workspace/fuzz_json/*.fuzz)" >> $GITHUB_OUTPUT
 
     # If a new crash was found, create an issue
-    - name: Create issue 
+    - name: Create issue
       uses: JasonEtco/create-an-issue@v2
-      if: ${{ steps.check_file_changed.outputs.report != '' }} 
+      if: ${{ steps.check_file_changed.outputs.report != '' }}
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         CRASH_REPORT: ${{ steps.check_file_changed.outputs.report }}

.github/workflows/hint_accountant.yml

@@ -2,29 +2,29 @@ name: Update missing hints tracking issue
 
 on:
   push:
-    branches: [ main ]
+    branches: [ main, starkware-development ]
 
 env:
   CARGO_TERM_COLOR: always
 
 jobs:
   run:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
     - name: Install Rust toolchain
-      uses: dtolnay/rust-toolchain@1.74.1
+      uses: dtolnay/rust-toolchain@1.85.0
     - name: Set up Cargo cache
       uses: Swatinem/rust-cache@v2
     - name: Checkout
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
     - name: Check Build
       run: cargo build -p hint_accountant
     - name: Clone cairo-lang repo
       run: git clone  --depth=1 https://github.com/starkware-libs/cairo-lang
     - name: Run the hint accounting script
       run: cargo r -p hint_accountant | tee comment.md
     - name: Update comment in tracking issue
-      uses: peter-evans/create-or-update-comment@v3
+      uses: peter-evans/create-or-update-comment@v4
       with:
         issue-number: 1031
         comment-id: 1518234161

.github/workflows/hyper_threading_benchmarks.yml

@@ -1,18 +1,21 @@
 name: Benchmark Hyper Threading
 
+permissions:
+  # permission to write a bench comment
+  issues: write
+  # permission to write a bench comment
+  pull-requests: write
+
 on:
   pull_request:
-    branches:
-      - main
+    branches: [ main, starkware-development ]
 
 jobs:
   benchmark:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout PR
-      uses: actions/checkout@v2
-      with:
-        ref: ${{ github.head_ref }}
+      uses: actions/checkout@v4
 
     - name: Setup Python
       uses: actions/setup-python@v4
@@ -26,7 +29,7 @@ jobs:
         sudo apt-get install -y hyperfine
 
     - name: Install Rust
-      uses: dtolnay/rust-toolchain@1.74.1
+      uses: dtolnay/rust-toolchain@1.85.0
       with:
         components: rustfmt, clippy
 
@@ -35,7 +38,7 @@ jobs:
         cargo build --release -p hyper_threading
         cp target/release/hyper_threading ${{ github.workspace }}/hyper_threading_pr
         cp ./examples/hyper_threading/hyper-threading-workflow.sh ${{ github.workspace }}/hyper-threading-workflow.sh
-    
+
     - name: Upload PR Binary
       uses: actions/upload-artifact@v4
       with:
@@ -50,7 +53,7 @@ jobs:
 
 
     - name: Checkout Main Branch
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       with:
         ref: 'main'
 
@@ -71,7 +74,7 @@ jobs:
         name: hyper_threading_workflow_script
         path: ${{ github.workspace }}/
 
-    - name: Compile programs 
+    - name: Compile programs
       run: make cairo_bench_programs
 
     - name: Run Benchmarks

.github/workflows/hyperfine.yml

@@ -6,7 +6,7 @@ on:
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
+  cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
 
 env:
   CARGO_TERM_COLOR: always
@@ -17,18 +17,18 @@ jobs:
       matrix:
         branch: [ base, head ]
     name: Build Cairo programs for ${{ matrix.branch }}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     outputs:
       benchmark-hashes-base: ${{ steps.export-hashes.outputs.benchmark-hashes-base }}
       benchmark-hashes-head: ${{ steps.export-hashes.outputs.benchmark-hashes-head }}
     steps:
       - name: Checkout base commit
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: ${{ github.event.pull_request[matrix.branch].sha }}
 
       - name: Fetch from cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         id: cache
         with:
           path: ${{ matrix.branch }}_programs/*.json
@@ -63,22 +63,22 @@ jobs:
       matrix:
         branch: [ base, head ]
     name: Build cairo-vm-cli for ${{ matrix.branch }}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Populate cache
-        uses: actions/cache@v3
-        id: cache 
+        uses: actions/cache@v4
+        id: cache
         with:
           path: bin/cairo-vm-cli-${{ matrix.branch }}
           key: binary-${{ github.event.pull_request[matrix.branch].sha }}
 
       - name: Install Rust
         if: ${{ steps.cache.outputs.cache-hit != 'true' }}
-        uses: dtolnay/rust-toolchain@1.74.1
+        uses: dtolnay/rust-toolchain@1.85.0
 
       - name: Checkout
         if: ${{ steps.cache.outputs.cache-hit != 'true' }}
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: ${{ github.event.pull_request[matrix.branch].sha }}
 
@@ -100,33 +100,33 @@ jobs:
         program_state: [ modified, unmodified ]
     name: Run benchmarks for ${{ matrix.program_state }} programs
     needs: [ build-programs, build-binaries ]
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
     - name: Install Hyperfine
       uses: taiki-e/install-action@v2
       with:
-        tool: hyperfine@1.16
+        tool: hyperfine@1.19
 
     - name: Fetch base binary
-      uses: actions/cache/restore@v3
+      uses: actions/cache/restore@v4
       with:
         path: bin/cairo-vm-cli-base
         key: binary-${{ github.event.pull_request.base.sha }}
 
     - name: Fetch HEAD binary
-      uses: actions/cache/restore@v3
+      uses: actions/cache/restore@v4
       with:
         path: bin/cairo-vm-cli-head
         key: binary-${{ github.event.pull_request.head.sha }}
 
     - name: Fetch base programs
-      uses: actions/cache/restore@v3
+      uses: actions/cache/restore@v4
       with:
         path: base_programs/*.json
         key: benchmarks-base-${{ needs.build-programs.outputs.benchmark-hashes-base }}
 
     - name: Fetch head programs
-      uses: actions/cache/restore@v3
+      uses: actions/cache/restore@v4
       with:
         path: head_programs/*.json
         key: benchmarks-head-${{ needs.build-programs.outputs.benchmark-hashes-head }}
@@ -175,7 +175,7 @@ jobs:
 
     - name: Find comment
       if: ${{ steps.run-benchmarks.outputs.benchmark_count != 0 }}
-      uses: peter-evans/find-comment@v2
+      uses: peter-evans/find-comment@v3
       id: fc
       with:
         issue-number: ${{ github.event.pull_request.number }}
@@ -184,14 +184,14 @@ jobs:
 
     - name: Create comment
       if: steps.fc.outputs.comment-id == '' && steps.run-benchmarks.outputs.benchmark_count != 0
-      uses: peter-evans/create-or-update-comment@v3
+      uses: peter-evans/create-or-update-comment@v4
       with:
         issue-number: ${{ github.event.pull_request.number }}
         body-path: comment_body.md
 
     - name: Update comment
       if: steps.fc.outputs.comment-id != '' && steps.run-benchmarks.outputs.benchmark_count != 0
-      uses: peter-evans/create-or-update-comment@v3
+      uses: peter-evans/create-or-update-comment@v4
       with:
         comment-id: ${{ steps.fc.outputs.comment-id }}
         body-path: comment_body.md

.github/workflows/iai_main.yml

@@ -2,16 +2,16 @@ name: iai Benchmark
 
 on:
   push:
-    branches: [ main ]
+    branches: [ main, starkware-development ]
 
 jobs:
   cache-iai-results:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
     - name: Checkout
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
     - name: Install Rust
-      uses: dtolnay/rust-toolchain@1.74.1
+      uses: dtolnay/rust-toolchain@1.85.0
     - name: Set up cargo cache
       uses: Swatinem/rust-cache@v2
     - name: Python3 Build