Skip to content

Commit 2647f05

Browse files
committed
Xcode build fixes.
1 parent e304657 commit 2647f05

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

CMakeLists.txt

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.12)
2-
set(CMAKE_OSX_DEPLOYMENT_TARGET "10.15" CACHE STRING "Minimum MacOS deployment version")
2+
#set(CMAKE_OSX_DEPLOYMENT_TARGET "10.15" CACHE STRING "Minimum MacOS deployment version")
33

44
project(LabRecorder
55
DESCRIPTION "Record and write LabStreamingLayer streams to an XDF file"
@@ -15,6 +15,9 @@ set(CMAKE_CXX_STANDARD_REQUIRED On)
1515

1616
option(BUILD_GUI "Build the GUI, set to off for CLI only build" ON)
1717

18+
set(CMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED "NO")
19+
set(CMAKE_XCODE_ATTRIBUTE_CODE_SIGN_IDENTITY "")
20+
1821
# Dependencies
1922

2023
## LSL
@@ -168,10 +171,11 @@ set(CPACK_DEBIAN_LABRECORDER_PACKAGE_SECTION "science" CACHE INTERNAL "")
168171
LSLGenerateCPackConfig()
169172

170173
if(APPLE AND NOT DEFINED ENV{GITHUB_ACTIONS})
171-
# Qt6 QtNetwork depends on libbrotidec which depends on libbroticommon but whose search path uses @loader_path. Unfortunately, macdeployqt
172-
# does not seem to traverse @loader_path dependencies. So we are forced to call `fixup_bundle`. For now, we only do this if homebrew is present
174+
# Qt6 QtNetwork depends on libbrotidec which depends on libbroticommon but whose search path uses @loader_path.
175+
# Unfortunately, macdeployqt does not seem to traverse @loader_path dependencies.
176+
# So we are forced to call `fixup_bundle`. For now, we only do this if homebrew is present
173177
# because that seems to be where the bad dependency is coming from.
174-
# Note that fixup_bundle also destory the codesigning so we have to redo that.
178+
# Note that fixup_bundle also destroys the codesigning so we have to redo that.
175179
# TODO: Checkout supercollider apple-specific stuff, e.g.: https://github.com/supercollider/supercollider/blob/develop/CMakeLists.txt#L260-L262
176180
execute_process(
177181
COMMAND brew --prefix

0 commit comments

Comments
 (0)