Skip to content

Conversation

@cubicj
Copy link
Contributor

@cubicj cubicj commented Oct 25, 2025

PR Checklist

  • Have you checked if it works normally in all models? Ignore this if it doesn't use models.
  • Have you checked if it works normally in all web, local, and node hosted versions? If it doesn't, have you blocked it in those versions?
  • Have you added type definitions?

Description

Issue

Sidebar avatar tooltips were not updating when characters were deleted, showing outdated names from previously selected characters.

Changes

Added update method to both tooltip and tooltipRight directives in src/ts/gui/tooltip.ts to dynamically update tooltip content when the tip parameter changes.

Technical Details

  • Implemented Svelte action update lifecycle method
  • Calls instance.setContent() to update Tippy.js tooltip content
  • Existing usages with static values are unaffected since update is only called when parameters change

Implementation

The update method is now called automatically by Svelte whenever the tip parameter changes, ensuring tooltips always display current information for dynamically updating components like SidebarAvatar.

Add update method to tooltip and tooltipRight directives to dynamically update tooltip content when the tip parameter changes. This fixes an issue where sidebar avatar tooltips showed outdated names after character deletion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant