Skip to content

Add new style icons to subscriptions #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johncowen opened this issue Nov 13, 2024 · 1 comment · Fixed by #3769
Closed

Add new style icons to subscriptions #3183

johncowen opened this issue Nov 13, 2024 · 1 comment · Fixed by #3769
Assignees
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@johncowen
Copy link
Contributor

johncowen commented Nov 13, 2024

Description

One thing I wanted to do with the subscriptions re-design was to add some icons back into each row denoting whether the subscriptions is connected or not. It would look similar to our Zone listings that have universal/kubernetes icons. I was thinking of using the VitalsIcon (https://kong.github.io/icons/?q=vitals) in green and the Remove Icon (https://kong.github.io/icons/?q=remove) which looks like a line, in grey.

Didn't quite get around to doing that, but we should circle back and do that.

edit: P.S. I also think we should add a single sentence explanation at the top of these tables to explain what subscriptions (aka XDS or KDS Connections) are.

@johncowen johncowen added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Nov 13, 2024
@lobkovilya lobkovilya added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Nov 18, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 17, 2025
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Feb 17, 2025
@lahabana lahabana added this to the 2.11.x milestone Mar 12, 2025
@schogges schogges self-assigned this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants