Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it payable with Libra-cli and other wallets #12

Open
totiz opened this issue Aug 2, 2019 · 4 comments
Open

Make it payable with Libra-cli and other wallets #12

totiz opened this issue Aug 2, 2019 · 4 comments

Comments

@totiz
Copy link
Contributor

totiz commented Aug 2, 2019

Right now we only support Libra Wallet POC, so I think we should allow simple full address and QR of full address that libra-cli users and other wallet can pay with.

So and payment page, we should have more options for this feature
Libra Merchant QR Payment

@totiz totiz changed the title Make it payable with Libra-cli Make it payable with Libra-cli and other wallets Aug 2, 2019
@lucasverra
Copy link

lucasverra commented Aug 7, 2019

correct me if im wrong but this is not possible today. Your animation of payment receive comes from pinging the internet (a webserver), not the libra blockchain. This way POC wallet informs (via internet) a server, then libramerchant getBalance each second

cf gif here http://recordit.co/nWPylYEHcn

In order to make it work

a. getbalance would need to ping API to check on blockchain
b. Blockchain would need to transmit an event ?

Curious to see next phase of dev ! keep it up :)

@totiz
Copy link
Contributor Author

totiz commented Aug 8, 2019

Correct me if I understand wrong,

You mean we should to reduce interval call to getBalance each second, to know that user already paid, am I right?

If so I suggest to add new issue for "Reduce interval checking of paid".

But for this issue, I mean to add new feature for libra-cli, because right now we introduce new QR format that other wallets may don't understand, for example if we show full address and ask user to sending libra coins to address for specific amount, then the rest will work as normally (will successfully show paid).

@lucasverra
Copy link

I mean to add new feature for libra-cli, because right now we introduce new QR format that other wallets may don't understand, for example if we show full address and ask user to sending libra coins to address for specific amount, then the rest will work as normally (will successfully show paid).

{"type":"peer_to_peer_payment","address":"42d0470ba549c63ad90ab3122fca00f1f57d1d21d8ece102548013bb960150cf","amount":"4.5","merchant":"CLASS CAFE"} indeed you need to get more generic and less custom. Only receiver address should be transmitted.
If not, you are just closing the ecosystem to your wallet, which is a non-sens to my regard at least.

So if i send now from a CLI to 42d0470ba549c63ad90ab3122fca00f1f57d1d21d8ece102548013bb960150cf, should i see the same animation ?

@totiz
Copy link
Contributor Author

totiz commented Aug 9, 2019

@lucasverra Yes, you can see the same animation actually you can try by decoding QR and copy address to libra-cli and send with bill amount. QR Format is used to communicate with Wallet to know address and amount need to pay. So if we have one more option on UI side, just show address and amount, that will be more easy for other wallet to pay with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants