enable go version update using the check_install_golang script

[prezha]

we've hit an issue with updating the go version on jenkins ci runners, which was required to fix another issue with the make generate-licenses, blocking our release

the details are in a rather lengthy slack debugging thread, but here's the tldr:

---

so, the issue is probably in the toolchain go1.23.4 line that we have set in the go.mod file and that's what go uses to respond back on go version, regardless of the actual go version installed (which explains why, when you start another-ssh session, you probably don't go into the minikube source dir, so the go version is not affected by the toolchain directive and returns the actually installed go version, and so you were able to update the go version as expected by manually running the script)

the "proof" whilst having go v1.23.3 installed:

$ pwd
/home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube

$ grep "^go\|^toolchain" go.mod
go 1.23.0
toolchain go1.23.4

$ go env | grep "GOROOT\|GOVERSION"
GOROOT='/home/prezha/dev/go/pkg/mod/golang.org/[email protected]'
GOVERSION='go1.23.4'

$ go version
go version go1.23.4 linux/amd64

going outside the minikube src dir:

$ cd

$ pwd
/home/prezha

$ go version
go version go1.23.3 linux/amd64

going back to the minikube src and removing the toolchain go1.23.4:

$ pwd
/home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube

$ grep "^go\|^toolchain" go.mod
go 1.23.0

$ go env | grep "GOROOT\|GOVERSION"
GOROOT='/usr/local/go'
GOVERSION='go1.23.3'

$ go version
go version go1.23.3 linux/amd64

that's probably "by design", but we oversaw it

---

this pr removes the toolchain directive and also bumps the go version in the go.mod, as for some reason, looks like the other pr did not do it (worth checking separatelly)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [prezha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[prezha]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20278) |
+----------------+----------+---------------------+
| minikube start | 51.3s    | 51.6s               |
| enable ingress | 18.1s    | 18.4s               |
+----------------+----------+---------------------+

Times for minikube start: 51.2s 51.4s 51.7s 50.9s 51.1s
Times for minikube (PR 20278) start: 53.2s 51.6s 49.3s 51.2s 52.7s

Times for minikube ingress: 18.5s 15.1s 18.5s 18.6s 19.6s
Times for minikube (PR 20278) ingress: 15.5s 19.6s 19.1s 18.6s 19.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20278) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 22.4s               |
| enable ingress | 12.6s    | 12.7s               |
+----------------+----------+---------------------+

Times for minikube start: 24.5s 24.6s 21.2s 21.0s 24.7s
Times for minikube (PR 20278) start: 20.9s 23.8s 25.0s 21.9s 20.3s

Times for minikube ingress: 12.3s 12.8s 12.3s 12.8s 12.8s
Times for minikube (PR 20278) ingress: 12.3s 12.3s 12.8s 12.3s 13.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20278) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 20.4s               |
| enable ingress | 29.2s    | 23.6s               |
+----------------+----------+---------------------+

Times for minikube start: 19.9s 19.3s 22.2s 21.9s 22.5s
Times for minikube (PR 20278) start: 20.0s 20.4s 20.1s 20.4s 21.0s

Times for minikube ingress: 22.8s 22.8s 22.8s 38.8s 38.8s
Times for minikube (PR 20278) ingress: 26.8s 22.8s 22.8s 22.8s 22.8s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
KVM_Linux_crio (6 failed)	TestFunctional/serial/SoftStart(gopogh)	11.11% (chart)

Besides the following environments also have failed tests:

• Docker_Cloud_Shell: 3 failed (gopogh)

• Docker_Linux_crio: 1 failed (gopogh)

• KVM_Linux_containerd: 2 failed (gopogh)

• Docker_Linux_crio_arm64: 1 failed (gopogh)

To see the flake rates of all tests by environment, click here.

[medyagh]

would it worth to use toolchain local?