Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ignore preflight checks from flag to kubeadm configurations #3141

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Dec 31, 2024

refer to kubernetes/kubernetes#129401

After we add SystemVerification check in upgrade, we need to skip in some kinder testing.

This PR follows the suggestions kubernetes/kubernetes#129401 (review) to move flags to configurations.

  • don't pass the --ignore-preflight errors as flags for commands.
  • pass them via config in the big config that has all the config 'kinds'.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 31, 2024
@k8s-ci-robot k8s-ci-robot added area/kinder Issues to track work in the kinder tool approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 31, 2024
@pacoxu pacoxu changed the title [WIP]add default ignore preflight checks for upgrade add default ignore preflight checks for upgrade Dec 31, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 31, 2024
@pacoxu pacoxu changed the title add default ignore preflight checks for upgrade move ignore preflight checks from flag to confiugrations Dec 31, 2024
@pacoxu pacoxu changed the title move ignore preflight checks from flag to confiugrations move ignore preflight checks from flag to kubeadm configurations Dec 31, 2024
@pacoxu pacoxu force-pushed the add-flags branch 2 times, most recently from d734d0a to 7bf3958 Compare December 31, 2024 03:44
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 31, 2024
@pacoxu pacoxu force-pushed the add-flags branch 2 times, most recently from 9b53a43 to 27cc4cb Compare December 31, 2024 05:19
@pacoxu
Copy link
Member Author

pacoxu commented Dec 31, 2024

/test

@k8s-ci-robot
Copy link
Contributor

@pacoxu: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-kubeadm-kinder-upgrade-latest
  • /test pull-kubeadm-kinder-verify

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pacoxu pacoxu requested a review from SataQiu December 31, 2024 06:14
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 63d8053 into kubernetes:main Dec 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants