-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move ignore preflight checks from flag to kubeadm configurations #3141
Conversation
d734d0a
to
7bf3958
Compare
9b53a43
to
27cc4cb
Compare
/test |
@pacoxu: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
refer to kubernetes/kubernetes#129401
After we add
SystemVerification
check in upgrade, we need to skip in some kinder testing.This PR follows the suggestions kubernetes/kubernetes#129401 (review) to move flags to configurations.