Fix FilterSpecByPathsWithoutSideEffects to handle cases without slash

[Jefftree]

The current FilterSpecByPathsWithoutSideEffects behavior is wrong for paths without a trailing slash. See comment thread for more details: https://github.com/kubernetes/kubernetes/pull/123770/files#r1516319191

cc @liggitt

[liangyuanpeng]

I agree that the safest thing to achieve the goal is to exclude exact matches on prefix and prefix+slash. The required modification looks small.

Is this something you want? If so I'll open a PR.

+++	prefixSet := sets.NewString(keepPathPrefixes...)
	for path, pathItem := range sp.Paths.Paths {
		if !prefixes.HasPrefix(path) {
			continue
		}
+++		if !strings.HasSuffix(path, "/") {
+++			continue
+++		}
+++		if !prefixSet.Has(path) {
+++			continue
+++		}
		ret.Paths.Paths[path] = pathItem
	}

[Jefftree]

From a quick glance I don't think it's correct but seems close. Here's a useful test case

FilterSpecByPathsWithoutSideEffects([]{"/apis/group/v1beta1/"}, []{"/apis/group/v1"}, ...} should return "" because despite v1 being a prefix of v1beta1, we should really be matching for "/apis/group/v1/...".

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[y1hao]

I saw this issue is rotten, so I'm trying to give it a go: #520. First time opening a PR, please let me know if I missed anything.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.