diff --git a/keps/sig-node/4742-node-topology-downward-api/README.md b/keps/sig-node/4742-node-topology-downward-api/README.md index b2975eb3294..ea8bbb56594 100644 --- a/keps/sig-node/4742-node-topology-downward-api/README.md +++ b/keps/sig-node/4742-node-topology-downward-api/README.md @@ -98,7 +98,7 @@ we aim to simplify access to this information for Pods via the Downward API. ### Goals -* Values from Node labels `topology.k8s.io/zone`, `topology.k8s.io/region` and `kubernetes.io/hostname` are made +* Values from Node labels `topology.kubernetes.io/zone`, `topology.kubernetes.io/region` and `kubernetes.io/hostname` are made available via downward API * Additional node labels can be made available via downward API using admission webhooks that mutate `pods/binding`. @@ -225,7 +225,8 @@ E2E tests will also ensure behavior is exercised when the feature gate is enable #### Beta -TODO after Alpha. +- Fix standard topology label used in PodTopologyLabels admission controller (topology.k8s.io -> topology.kubernetes.io) +- Unit, integration and e2e tests #### GA @@ -290,7 +291,9 @@ Tests will be added to ensure feature gate works as expected. ### Rollout, Upgrade and Rollback Planning -TODO for Beta. +Manual testing will be exercised to ensure that PodTopologyLabelsAdmission can be enabled and then disabled. +When disabled, existing Pods with topology labels will continue to run with those labels and new Pods will no longer +container topology labels. ###### How can a rollout or rollback fail? Can it impact already running workloads? @@ -402,6 +405,7 @@ Revert feature gate and stop consuming downward API. ## Implementation History - `v1.33`: initial KEP is accepeted and alpha implementation is complete +- `v1.34`: fix topology labels from topology.k8s.io to topology.kubernetes.io. ## Drawbacks diff --git a/keps/sig-node/4742-node-topology-downward-api/kep.yaml b/keps/sig-node/4742-node-topology-downward-api/kep.yaml index c5e8301abc3..fc9ddddb220 100644 --- a/keps/sig-node/4742-node-topology-downward-api/kep.yaml +++ b/keps/sig-node/4742-node-topology-downward-api/kep.yaml @@ -26,12 +26,12 @@ stage: alpha # The most recent milestone for which work toward delivery of this KEP has been # done. This can be the current (upcoming) milestone, if it is being actively # worked on. -latest-milestone: "v1.33" +latest-milestone: "v1.34" # The milestone at which this feature was, or is targeted to be, at each stage. milestone: alpha: "v1.33" - # beta: "v1.34" + beta: "v1.35" # stable: "v1.35" # The following PRR answers are required at alpha release