@@ -281,8 +281,8 @@ spec:
281281` ` ` yaml
282282apiVersion: v1
283283kind: Pod
284- name :
285- jobset-job-1-abc123
284+ metadata :
285+ name: jobset-job-1-abc123
286286spec:
287287 ...
288288 workload:
@@ -293,15 +293,15 @@ spec:
293293
294294` ` `
295295
296- We decided for this option because it is more succint and makes the role of a pod clear just
296+ We decided for this option because it is more succinct and makes the role of a pod clear just
297297from inspecting the pod (and simple/efficient to group).
298298We acknowledge the fact that this option may require additional minor changes in the controllers
299299to adopt this pattern (e.g. for LeaderWorkerSet we will need to populate the pod template
300300similarly that we currently populate the labels).
301301
302- The primary alternative we consider was to introduce the the `PodGroupSelector` on each `PodGroup`
302+ The primary alternative we consider was to introduce the `PodGroupSelector` on each `PodGroup`
303303to identify pods belonging to it. However, with this pattern :
304- - there are additional corner cases (e.g. a pod links to a workload but none of its PodGroups matching
304+ - there are additional corner cases (e.g. a pod links to a workload but none of its PodGroups match
305305 that pod)
306306- for replicated gang, we can't use the full label selector, but rather support specifying only the
307307 label key, similar to `MatchLabelKeys` in pod affinity
@@ -438,7 +438,7 @@ For `Beta`, we want to also touch requirements (2) and (3) by extending the sche
438438a new dedicated phase (tentatively called Workload). In that phase,
439439kube-scheduler will be looking at all pods from a gang (part of `Workload`) and compute the placement
440440for all of these pods in a single scheduling cycle. Those placements will be stored only in-memory and
441- block the required resources from scheduling. Tentively we plan to use `NominatedNodeName` field for it.
441+ block the required resources from scheduling. Tentatively we plan to use `NominatedNodeName` field for it.
442442After that, pods will go through regular pod-by-pod scheduling phases (including Filter and Score)
443443with a nomination as a form of validation the proposed placement and execution of this placement decision.
444444Therefore we expect the order of processing pods won't ever be important, but all-or-nothing nature of
0 commit comments