[occm] Deprecate "DeprecatedLabelNodeRoleMaster"

[jonatasbaldin]

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:
The DeprecatedLabelNodeRoleMaster label, which prevents the control plane nodes to create a LoadBalancer, is still being checked. The implementation of LabelNodeExcludeLB is on Kubernetes since v1.22 and I believe we can finally deprecate the old label.

cloud-provider-openstack/pkg/ingress/controller/controller.go

Line 96 in 7c95815

DeprecatedLabelNodeRoleMaster = "node-role.kubernetes.io/master"

cloud-provider-openstack/pkg/ingress/controller/controller.go

Line 254 in 7c95815

if _, hasNodeRoleMasterLabel := node.Labels[DeprecatedLabelNodeRoleMaster]; hasNodeRoleMasterLabel {

I have an edge case where I need the control plane nodes to become members of a LoadBalancer and I believe that this check is preventing that.

What you expected to happen:
Deprecate the DeprecatedLabelNodeRoleMaster flag to have control plane nodes as members of a LoadBalancer.

Environment:

• openstack-cloud-controller-manager(or other related binary) version: master branch