-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation of ProvisioningRequest's Parameters #7511
Comments
/area cluster-autoscaler |
I can help with that. |
I added CEL validation in the CRD to validate parameters for check-capacity.autoscaling.x-k8s.io provisioning class, what do you think? |
If looks valid we can remove those lines: |
Looks great, thanks @omerap12
Agreed |
Thanks, so I will have another commit to clean the previous approach |
@PBundyra Done. |
Which component are you using?:
cluster-autoscaler
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
Currently if a user sets invalid key or values of ProvisioningRequest's Parameter they get no information that the Parameters is invalid.
Describe the solution you'd like.:
Validate keys and values of supported ProvisioningRequest's Parameters
Describe any alternative solutions you've considered.:
Not validate parameters and rely on the user to provide correct keys and values
Additional context.:
#7496 (comment)
The text was updated successfully, but these errors were encountered: